RevisionableStorageInterface::loadRevision should accept both string and int

Issue created by @dpi
Comment about 1 year ago →
🇦🇺Australia dpi Perth, Australia
It would be easy to copy the param doc from \Drupal\Core\Entity\EntityStorageInterface::loadRevision from the Drupal 10 branches (it is deprecated for D11)
Status changed to Needs review about 1 year ago2:49am 30 September 2023
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,360 pass
Comment about 1 year ago →
🇮🇳India Soham Sengupta
Hi, I have updated the param doc. Please review.
Status changed to RTBC about 1 year ago6:41pm 30 September 2023
Comment about 1 year ago →
🇺🇸United States smustgrave
Param doc was copied from \Drupal\Core\Entity\EntityStorageInterface::loadRevision
Comment about 1 year ago →
🇦🇺Australia dpi Perth, Australia
LGTM
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,360 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,371 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,377 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,382 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,384 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,394 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,397 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,411 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
28:47
25:24
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,420 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,426 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,434 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,438 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,464 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,481 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,483 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,486 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,486 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.2 & MySQL 8
last update about 1 year ago
30,493 pass
Status changed to Needs work about 1 year ago8:58am 9 November 2023
Comment about 1 year ago →
🇬🇧United Kingdom alexpott 🇪🇺🌍
I think this issue should go a bit further and make consistent.

\Drupal\Core\Entity\EntityRepository::loadRevision()
\Drupal\Core\Entity\RevisionableInterface::getLoadedRevisionId()
\Drupal\Core\Entity\RevisionableStorageInterface::deleteRevision()

I also think it is worth asking is it really true that revision IDs can be non numeric strings. Yes entity IDs can be strings but that is not the same as a revision ID. I think a revision ID should always be an integer - I'd be amazed if there is any true string revision IDs in contrib or custom. So maybe the fix here is to change them to int and add some casting.

RevisionableStorageInterface::loadRevision should accept both string and int

Problem/Motivation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities