- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Under https://www.drupal.org/about/core/policies/core-change-policies/allowed-... → - I don't think so.
Published the change record.
- 🇺🇸United States bradjones1 Digital Nomad Life
Is this eligible to go into D10 LTS?
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 11.x - thanks
We've got ~6 months to find any issues downstream from here - likely started with JSON API extras which is maintained by several of the people in this issue.
Great work all
-
larowlan →
committed 8e29ee2b on 11.x
Issue #3031367 by bradjones1, bbrala, gabesullice, wim leers, larowlan,...
-
larowlan →
committed 8e29ee2b on 11.x
- 🇳🇱Netherlands bbrala Netherlands
All things have been adressed.
Exciting times :)
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Some questions on the MR, will keep an eye out for when this is addressed, as getting this into 11.2 early is a priority
- 🇳🇱Netherlands bbrala Netherlands
Rebasing took a little effort because we need to deprecate some extra arguments. I also had to undo contructor promotion since the merged json:api metadata issue changed the contructor parameter.
I think the changes are small enough no to warrent a new review, all is green still.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
✨ Allow specifying `meta` data on JSON:API objects Needs work is in!
- 🇺🇸United States bradjones1 Digital Nomad Life
This is likely due to ✨ Allow specifying `meta` data on JSON:API objects Needs work going in which is a good thing. Needs a rebase then should be back to RTBC.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 11.x - great work folks
Published the CR
-
larowlan →
committed 662da7ee on 11.x
Issue #3100732 by bbrala, bradjones1, mglaman, wim leers, ptmkenny,...
-
larowlan →
committed 662da7ee on 11.x
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇬🇧United Kingdom joachim
> Already in core — see this for ckeditor5.plugin.ckeditor5_language for example:
Yes but that's only the option values. It doesn't define the option labels.
The labels are needed for decoupled UIs, and also for translation.
