Or we figure out that we don't actually need to declare these things as completely uncachable anymore.
For instance, what if we decide to rely on SameSite=Lax rather than using our custom CSRF protection? This is what other projects like Next.js do and maybe that would be fine for us as well?
i think you won't be able to solve such problems without client side javascript code that updates part of the page outside the context of the whole page caching .
That seems fine?
In my mind, undercaching is always prefered to overcaching. In an ideal world, it would be perfectly cached, but if the form (or whatever) declares that the whole page is uncachable because of it's inclusion, then.... it is what it is. The only thing you can do is refactor that element to be cacheable (i.e. generate the dynamic bits with JS and/or WebAssembly)
I'm still subscribed to this issue 8 years later and I re-read the duplicate I created → and I'm still thinking about this:
There are existing issues for this, it's mostly by design and I'm not sure if it can be changed. It would result in many pages no longer being cacheable that currently are, for example as forms declare themself as uncacheable.
And now I'm wondering.... so what? Like if a bunch of things become uncachable in Drupal 11 and we go and fix those things (individually) in 11.1+ that seems... fine? Am I missing something here?
Yeah sorry about that. Something on Azure is borken so I'm migrating back to my Pi which is cheaper anyways.
Rebased
I created a new merge request that is more incremental, and I think should solve my problem without having to add the Transport to the DI container.
https://git.drupalcode.org/project/drupal/-/merge_requests/5847
Please take a look and let me know what you think!
Would you accept a middle ground? Perhaps a TransportFactoryManager that just collects tagged transports, but doesn't create the Symfony Transport object?
I don't understand these test failures, if anyone could help explain them I would be much appreciated!
davidwbarratt → created an issue.
davidwbarratt → created an issue.
davidwbarratt → created an issue.
Adding attribution
davidwbarratt → created an issue.
davidwbarratt → created an issue.
davidwbarratt → created an issue.
davidwbarratt → created an issue.
davidwbarratt → created an issue.
done! Thanks for your help!