Cannot save a custom transport because the Symfony static Transport class is used

Created on 26 November 2023, about 1 year ago

Updated 14 February 2024, 10 months ago

Problem/Motivation

Similar to ✨ Ability to use custom transports with symfony/mailer Needs work .

When attempting to use a custom transport like hafael/azure-mailer-driver the transport is registered (by adding a new service with the appropriate tag), but it is impossible to save the DSN without an error like:

Invalid DSN: The "azure" scheme is not supported.

This is because of this line:
https://git.drupalcode.org/project/symfony_mailer/-/blob/4e9c789065a8bc9...

which only uses the "default" factories and not the injected factories.

Steps to reproduce

Add hafael/azure-mailer-driver

Create a service with config like:

    azure_mailer.transport_factory:
      class: Hafael\Azure\Transport\AzureMailerTransportFactory
      tags:
        - { name: mailer.transport_factory }

Attempt to save an azure DSN

Proposed resolution

Use a service with the injected transport factories rather than the static class.

Remaining tasks

Write a patch
Test patch

User interface changes

N/A

API changes

Registered DSNs will work where previously they did not.

Data model changes

N/A

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States davidwbarratt

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @davidwbarratt
Comment about 1 year ago →
🇺🇸United States davidwbarratt
Comment about 1 year ago →
🇺🇸United States davidwbarratt
Comment about 1 year ago →
🇺🇸United States davidwbarratt
Comment about 1 year ago →
🇬🇧United Kingdom adamps
Great thanks for the report.

Let's call this normal priority because custom transports are an uncommon case - I believe the code has been like that for some time and no one else noticed!

It's a bit awkward to fix, as the full correct list of transports is only available in the Mailer class. I guess we can add an @internal function to that validates a DSN.

Eventually Core issue 📌 [PP-1] Add symfony mailer transports to DIC Postponed will hopefully define a proper service that we could use.
Comment 10 months ago →
🇬🇧United Kingdom adamps

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024