The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- First commit to issue fork.
- Status changed to Needs review
3 months ago 7:10am 6 August 2024 - Status changed to Needs work
3 months ago 10:04pm 11 August 2024 - 🇺🇸United States smustgrave
Can issue summary and title be updated this is about removing dead code now?
- Status changed to Needs review
3 months ago 4:27am 12 August 2024 - Status changed to RTBC
3 months ago 12:39pm 12 August 2024 - Status changed to Needs work
3 months ago 12:25pm 17 August 2024 - 🇬🇧United Kingdom catch
Shouldn't the classes and services be deprecated in 11.x for removal in 12.x?
- 🇺🇸United States smustgrave
Do you think anyone could be using them? Seemed like dead code?
- 🇬🇧United Kingdom catch
It's still used in HAL, which is mentioned in the issue summary. https://git.drupalcode.org/project/hal/-/blob/1.x/src/Normalizer/EntityR...
There are 30,000 sites using the module.