- π΅π±Poland lamp5 Rzeszow
In my opinion, we should create a new branch 2.x to provide full compatibility with Drupal 9.1.x+ and improve phpdocs to return correct instance.
- πΊπΈUnited States mglaman WI, USA
We don't need a new branch, Drupal 9 isn't supported. No longer blocked.
- πΊπΈUnited States mglaman WI, USA
The code already has:
// \Drupal\jsonapi\ResourceResponse no longer implements // CacheableResponseInterface in Drupal 9.1. // Drupal\jsonapi\CacheableResourceResponse has ben added for cacheable // responses. Keep compatibility with Drupal < 9.1. // See https://www.drupal.org/node/3163310 $document = new JsonApiDocumentTopLevel($data, $includes, $links, $meta); $response = class_exists('\Drupal\jsonapi\CacheableResourceResponse') ? new CacheableResourceResponse($document, $response_code, $headers) : new ResourceResponse($document, $response_code, $headers);
From #3187549: Become compatible with Drupal 9.1 β
I think we can use this ticket to bump to 9.1 support minimum.
- Merge request !7Only use cacheable resource response if request is cacheable β (Merged) created by mglaman
- Status changed to Needs review
9 months ago 3:26pm 19 March 2024 - πΊπΈUnited States mglaman WI, USA
MR needs review. CacheableResourceResponse is only used if the request is cacheable, like Drupal core.
-
mglaman β
committed a331bad3 on 8.x-1.x
Issue #3155966 by mglaman, pixelwhip: ResourceResponseFactory to return...
-
mglaman β
committed a331bad3 on 8.x-1.x
- Status changed to Fixed
9 months ago 12:17pm 3 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.