This issue was committed then reverted due to the missing service. I'm reopening it with an updated merge request that includes the omitted lock service.
Thanks for reporting this. I've opened a merge request that needs review.
pixelwhip → made their first commit to this issue’s fork.
Present!
I've come across this bug before. This happens when `npm install` has been run inside the `prototype` theme itself. The problem is that Drupal theme rename utility is replacing all instances of the sting "prototype" which is a reserved property name in JS. Typically deleting the `node_modules` folder and re-running the script will fix it.
Thanks for reporting this. This has been fixed in the 1.x branch.
pixelwhip → made their first commit to this issue’s fork.
This has been fixed on the 1.0.x branch
Thanks for this. Tested and merged.
pixelwhip → created an issue.
pixelwhip → created an issue.
Released in version 2.2.3
Dragula is a dependency of Layout Paragraphs, not Mercury Editor – at least not directly. The Layout Paragraphs module readme has installation instructions specifically for installing Dragula either manually or through Composer (recommended).
I'm marking this "works as designed". There have been a number of conflicts with ME and Gin in the past since both make significant alterations to the node edit page. The "Mercury Editor Edit Tray Theme" config setting, mentioned in #10, was introduced specifically because of this conflict. This allows you to use Gin as your general admin theme and Claro as your ME editor theme.
I realize Gin is a popular admin theme and using two different admin themes on a single site can lead to inconsistencies with the admin interface. However, I think it would be best to handle these conflicts in a separate module or theme specific to sites needing Gin as the Mercury Editor Tray Theme. This would make it easier to manage dependencies.
This is fixed in the latest 3.0.x branch
Thanks for this fix. I've rerolled this change on the latest form 2.2.x and merged it in.
pixelwhip → changed the visibility of the branch 2.2.x to hidden.
pixelwhip → made their first commit to this issue’s fork.
Noting that this will redirect to the draft revision if there is no published revision. When saving and exiting from a newly created unpublished node for example.
pixelwhip → created an issue.
pixelwhip → created an issue.
pixelwhip → created an issue.
pixelwhip → created an issue.
Present!
I've run into this with Mercury Editor → 's service and MercuryEditorContextService and ThemeNegotiator services.
Neither are able to detect if the given route is a preview or editing route because RouteMatch->createFromRequest() is unable to match a route when Account administration pages is configured as the first detection option. In the case, createFromRequest() is returning NullRouteMatch.php
The above merge request resolves the issue for me.
pixelwhip → created an issue.
pixelwhip → made their first commit to this issue’s fork.
jldust → credited pixelwhip → .
Present!
I think this behavior belongs in the JS of the layout itself.
Rather than listening for a custom event provided by Layout Paragraphs, I'd recommend writing a MutationObservor and calling the reflow, rerender, refresh etc. whenever attributes or the subtree change. This approach would not require extra API surface in Layout Paragraphs, use existing browser functionality and will work with whatever conceivable thing that might dynamically alter the layout client side – not just Layout Paragraphs.
pixelwhip → created an issue.
pixelwhip → created an issue.
This sets the logical-properties-and-values configuration to false
pixelwhip → created an issue.
Added a bleed modifier based on a conversation in our latest Prototype dev meeting.
Present!
pixelwhip → made their first commit to this issue’s fork.
Tested this update and it resolved the issue for me. Merged.
pixelwhip → made their first commit to this issue’s fork.
This has been addressed. Please use 1.3.0 or 2.x-dev for Drupal 11 compatibility.
You are correct. The SDC module dependency was deprecated in 10.3 and removed in D11. Will release a new version shortly.
https://www.drupal.org/node/3410260 →
Good catch! This is ready for review.
pixelwhip → made their first commit to this issue’s fork.
Present!
This solution isn't perfect as the specific character or element that is clicked on may move slightly due to minor style changes between the preview content and content in an active editor, but it does get much closer.
pixelwhip → made their first commit to this issue’s fork.
This looks good to me!
jldust → credited pixelwhip → .
Present!
This dependency has been updated on the 1.1.x and 2.x branches. The 1.0.x branch is intended to be left as is to support the contrib version of SDC.
Is this still an issue on the latest 2.x version?
Good news! This was already fixed in the latest release thanks to https://www.drupal.org/project/mercury_editor/issues/3489991 🐛 Mercury tray resizes when entity browser modal dialogs are opened Active
pixelwhip → created an issue.
Rebased this onto the latest from 5.x
Thank you for reporting this issue. Ultimately the fix was related to some existing stylesheets not being loaded as intended which was fixed in https://www.drupal.org/project/prototype/issues/3501297 🐛 Some base stylesheets are not being loaded Active .
pixelwhip → created an issue.
pixelwhip → created an issue.
pixelwhip → created an issue.
pixelwhip → created an issue.
pixelwhip → created an issue.
I can also confirm patch #15 fixes this issue for me.
The above merge request adds a tabs single-directory component and refactors the tabs.js to include keyboard handling and separates the drupal specific js functionality into its own file.