🇺🇸United States @pixelwhip

pixelwhip → made their first commit to this issue’s fork.

Tested this update and it resolved the issue for me. Merged.

pixelwhip → made their first commit to this issue’s fork.

This has been addressed. Please use 1.3.0 or 2.x-dev for Drupal 11 compatibility.

You are correct. The SDC module dependency was deprecated in 10.3 and removed in D11. Will release a new version shortly.
https://www.drupal.org/node/3410260 →

Good catch! This is ready for review.

pixelwhip → made their first commit to this issue’s fork.

Present!

This solution isn't perfect as the specific character or element that is clicked on may move slightly due to minor style changes between the preview content and content in an active editor, but it does get much closer.

pixelwhip → made their first commit to this issue’s fork.

This looks good to me!

jldust → credited pixelwhip → .

Present!

This dependency has been updated on the 1.1.x and 2.x branches. The 1.0.x branch is intended to be left as is to support the contrib version of SDC.

Is this still an issue on the latest 2.x version?

Good news! This was already fixed in the latest release thanks to https://www.drupal.org/project/mercury_editor/issues/3489991 🐛 Mercury tray resizes when entity browser modal dialogs are opened Active

pixelwhip → created an issue.

Rebased this onto the latest from 5.x

Thank you for reporting this issue. Ultimately the fix was related to some existing stylesheets not being loaded as intended which was fixed in https://www.drupal.org/project/prototype/issues/3501297 🐛 Some base stylesheets are not being loaded Active .

pixelwhip → created an issue.

pixelwhip → created an issue.

pixelwhip → created an issue.

pixelwhip → created an issue.

pixelwhip → created an issue.

I can also confirm patch #15 fixes this issue for me.

The above merge request adds a tabs single-directory component and refactors the tabs.js to include keyboard handling and separates the drupal specific js functionality into its own file.

pixelwhip → created an issue.

Should (and can) the type property be more flexible to allow passing in simple arrays of attributes? The template will support it but I'm not sure how that affects validation.

Something like...

props:
  type: object
  properties:
    attributes:
      type: ['Drupal\Core\Template\Attribute', 'object', 'null']
      title: Attributes
      description: Wrapper attributes.

pixelwhip → created an issue.

Thank you! This has been merged into the 2.0.x branch.

TIL '1234' is a valid HTML ID but '#1234' is not a valid CSS selector. This is ready for review.

pixelwhip → made their first commit to this issue’s fork.

pixelwhip → created an issue.

This has been added to the 2.0.x branch.

pixelwhip → created an issue.

I've created a merge request based which is a reroll of #5 against the 2.1.x branch. Note that this allows users to save the order of the list when it contains duplicate entities, but it does not allow the user to independently sort the entity. The additional entities are not given their own weight.

pixelwhip → made their first commit to this issue’s fork.

pixelwhip → made their first commit to this issue’s fork.

pixelwhip → made their first commit to this issue’s fork.

Thanks! This feature will be useful.

pixelwhip → made their first commit to this issue’s fork.

pixelwhip → created an issue.

Reviewing tickets.

I've updated the merge request to handle various types of nested menus including those that are expanded and have a link as the root menu item. The escape and left keys now only escapes to the closest button in case of nested menus. This behavior more closely matches https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-naviga...

jldust → credited pixelwhip → .

This has been updated for 10 and 11.

This has been merged. Will release a 1.0.0 version.

This is ready for review. It has been rebased onto the latest 5.x branch.

Reviewed the component folder structure changes and menu component updates.

Unfortunately, I don't think that change worked. I still think Cypress tests are failing in Tugboat. Need to try clearing the cache before trying to enable the theme.

Rebased onto the latest from 5.x.

This has been squashed and merged into 5.x

Good catch on the :root styles. I did wonder about those. I think the only time :root styles outside of 00-base are appropriate is if they are component specific. In which case they should be namespaced as --prototype-[component-name]-[property]. I thought that was a little ambiguous with the grid and width custom props. I had to ask if these properties could be applicable outside of the context of those utility classes and figured they could be, but am not 100% convinced. I moved them for now for consistency sake. I also updated the grid property to leverage the spacing props.

I added a blank stylesheet for the page template. I removed the landing page folder as I don't think we should have more than one example folder without a corresponding template. Otherwise it's more stuff that may need to be deleted. It probably is a good idea to have a starter landing page template with corresponding styles but that could be another issue.

This looks good to me!

pixelwhip → made their first commit to this issue’s fork.

I've added the initial configuration for the plugin and updated a couple files as a proof of concept.

Marking this postponed until 3469567 📌 Component Folder Structure Needs work is resolved to avoid the inevitable merge conflicts.

pixelwhip → created an issue.

@jldust & @philip_stier I've made some updates to this and it's ready for review again.

1. Moved any element selectors to the 01-elements
2. Moved layouts in 03-layouts
3. Moved the regions to 04-regions
4. Adjusted the cypress tests to work with the new structure.
5. Updated the libraries.yml file to match

Closed and reopened the merge request to get tugboat to rebuild.

Rebased the merge request onto the latest 5.x.

pixelwhip → made their first commit to this issue’s fork.

Subscribe!

We've been using Cypress via TugBoat for Mercury Editor → and our Prototype → theme. I haven't personally used Playwright yet. I'm excited to try it out soon as Mercury Editor requires extensive testing across iframes and from what I've read, Playwright handles that better than Cypress out of the box.

This was a good bug find. Thanks for getting this fixed.

This change makes a lot of sense to me! Merge request looks good.

I think we can deprecate v4 today with instructions on how to move away from it.

pixelwhip → created an issue.