Present!
I've run into this with Mercury Editor → 's service and MercuryEditorContextService and ThemeNegotiator services.
Neither are able to detect if the given route is a preview or editing route because RouteMatch->createFromRequest() is unable to match a route when Account administration pages is configured as the first detection option. In the case, createFromRequest() is returning NullRouteMatch.php
The above merge request resolves the issue for me.
pixelwhip → created an issue.
pixelwhip → made their first commit to this issue’s fork.
jldust → credited pixelwhip → .
Present!
I think this behavior belongs in the JS of the layout itself.
Rather than listening for a custom event provided by Layout Paragraphs, I'd recommend writing a MutationObservor and calling the reflow, rerender, refresh etc. whenever attributes or the subtree change. This approach would not require extra API surface in Layout Paragraphs, use existing browser functionality and will work with whatever conceivable thing that might dynamically alter the layout client side – not just Layout Paragraphs.
pixelwhip → created an issue.
pixelwhip → created an issue.
This sets the logical-properties-and-values configuration to false
pixelwhip → created an issue.
Added a bleed modifier based on a conversation in our latest Prototype dev meeting.
Present!
pixelwhip → made their first commit to this issue’s fork.
Tested this update and it resolved the issue for me. Merged.
pixelwhip → made their first commit to this issue’s fork.
This has been addressed. Please use 1.3.0 or 2.x-dev for Drupal 11 compatibility.
You are correct. The SDC module dependency was deprecated in 10.3 and removed in D11. Will release a new version shortly.
https://www.drupal.org/node/3410260 →
Good catch! This is ready for review.
pixelwhip → made their first commit to this issue’s fork.
Present!
This solution isn't perfect as the specific character or element that is clicked on may move slightly due to minor style changes between the preview content and content in an active editor, but it does get much closer.
pixelwhip → made their first commit to this issue’s fork.
This looks good to me!
jldust → credited pixelwhip → .
Present!
This dependency has been updated on the 1.1.x and 2.x branches. The 1.0.x branch is intended to be left as is to support the contrib version of SDC.
Is this still an issue on the latest 2.x version?
Good news! This was already fixed in the latest release thanks to https://www.drupal.org/project/mercury_editor/issues/3489991 🐛 Mercury tray resizes when entity browser modal dialogs are opened Active
pixelwhip → created an issue.
Rebased this onto the latest from 5.x
Thank you for reporting this issue. Ultimately the fix was related to some existing stylesheets not being loaded as intended which was fixed in https://www.drupal.org/project/prototype/issues/3501297 🐛 Some base stylesheets are not being loaded Active .
pixelwhip → created an issue.
pixelwhip → created an issue.
pixelwhip → created an issue.
pixelwhip → created an issue.
pixelwhip → created an issue.
I can also confirm patch #15 fixes this issue for me.
The above merge request adds a tabs single-directory component and refactors the tabs.js to include keyboard handling and separates the drupal specific js functionality into its own file.
pixelwhip → created an issue.
Should (and can) the type property be more flexible to allow passing in simple arrays of attributes? The template will support it but I'm not sure how that affects validation.
Something like...
props:
type: object
properties:
attributes:
type: ['Drupal\Core\Template\Attribute', 'object', 'null']
title: Attributes
description: Wrapper attributes.
pixelwhip → created an issue.
Thank you! This has been merged into the 2.0.x branch.
TIL '1234' is a valid HTML ID but '#1234' is not a valid CSS selector. This is ready for review.
pixelwhip → made their first commit to this issue’s fork.
pixelwhip → created an issue.
This has been added to the 2.0.x branch.
pixelwhip → created an issue.
I've created a merge request based which is a reroll of #5 against the 2.1.x branch. Note that this allows users to save the order of the list when it contains duplicate entities, but it does not allow the user to independently sort the entity. The additional entities are not given their own weight.
pixelwhip → made their first commit to this issue’s fork.
pixelwhip → made their first commit to this issue’s fork.
pixelwhip → made their first commit to this issue’s fork.
Thanks! This feature will be useful.
pixelwhip → made their first commit to this issue’s fork.
pixelwhip → created an issue.
Reviewing tickets.