Remove @todo and workaround in Cookie ResourceTestTrait

Created on 7 April 2017, about 7 years ago
Updated 7 March 2024, 4 months ago

Problem/Motivation

Original report:

\Drupal\block\BlockAccessControlHandler::mergeCacheabilityFromConditions() causes the current user's cache tag to be associated with the access result.

Even though there should not be such a cache tag, only the user.roles cache context (which is also present).

I tried to find the root cause, but quickly got lost in the complexity of the context system.

Discovered in #2765959: Make 4xx REST responses cacheable by (Dynamic) Page Cache + comprehensive cacheability test coverage β†’ .

Proposed resolution

Bug since fixed elsewhere, and the MR just removes the workaround and @todo added in #2765959

πŸ“Œ Task
Status

Fixed

Version

10.2 ✨

Component
RESTΒ  β†’

Last updated about 1 month ago

Created by

πŸ‡§πŸ‡ͺBelgium Wim Leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024