REST views: pagination information and total count result

I have successfully tested patch #54

Thank you for testing, however, the failing tests with patch needs to be addressed to make this pass code quality. Manual tests alone is not enough.

tunic → changed the visibility of the branch 11.x to hidden.

I've created an issue fork and committed patch from #54.

I've tried to fix the tests, one comes from the schema configuration, not sure if I did it right.

Let's see what tests say.

Moving to NR to trigger testing.

Tests passed.

I've split the render function adding a new wrapRowsInPager function called when the pager is enabled. This makes the main render function cleaner and shorter. Also, it allows to document the new code in the new function header.

Additionally, values in the pager are passed through intval because some of them were return as strings in the JSON response.

Tests still ok.

Left a comment on MR.

I need help here.

Tests complain about the schema. Examples:

• https://git.drupalcode.org/issue/drupal-2982729/-/jobs/869401#L4367
• https://git.drupalcode.org/issue/drupal-2982729/-/jobs/869399#L4117

However, I did update the schema, see https://git.drupalcode.org/project/drupal/-/merge_requests/6558/diffs#76...

Does the schema needs to de declared elsewhere? Is the updated schema wrong?

Not the best with schema but wonder if the update needs to be in views.

Thanks for quick response, smustgrave.

If you mean fixing the schema I guess not because in rest/config/schema/ you can see the schema for the "format" key that is in the same form as the added "pager", so it seems the right place.

If you mean the updating process to add "pager" to all the views missing it I'm not sure but the failing tests doesn't seem to be related to an update process (although I'm not sure how to test a core update using tests).

But.. I'm not very good with schema, so I could be totally wrong. The only option to check this is to move the update process (the rest_update_11001 function) to views.install, I guess...

Any schema expert in the room?

Adding a verb to imply a feature request, not an error.