malik.kotob β made their first commit to this issueβs fork.
malik.kotob β created an issue.
I ran into this same issue! The patch as-is didn't quite work, but not because the code itself wasn't sound. It seems the patch formatting itself had an issue? Here's the patch I used (the code was borrowed @wendell in the original patch). Note that I was able to reproduce this when adding an inline block via Layout Builder.
The code from the latest patch looks sound (at least to me :D), and I can confirm that the code fixes the issues I was previously facing.
Thanks Pavel!
Tested and worked very well!
malik.kotob β made their first commit to this issueβs fork.
malik.kotob β created an issue.
Hello! I tested the patch on 10.1.4 using DrupalPod, and it worked well! I also tested with a layout builder visibility controls patch β¨ Add visibility control conditions to blocks within Layout Builder Needs work applied, and it worked great. Things are also working with my current Drupal version (9.5.9).
Hi @vishal.kadam! As a former student and current colleague of Ashraf's I can attest to his expertise in writing secure code and more broadly speaking as someone with significant professional Drupal development experience. I have personally been mentored and taught by Ashraf and use the skills I learned through his Drupal bootcamp on a daily basis in my role as a lead architect for Pantheon :)
I'm also a former architect at Acquia and CivicActions. Hope this helps with the approval process, looks like a great idea for a module!
malik.kotob β created an issue.
Merge request is up!
Requires contrib modules to test:
- Facets
- better exposed filters
- views_ajax_get
Testing steps:
- Enable the required contrib modules
- Login to your site
- Visit /admin/structure/views/settings/advanced and enable views_ajax_get extender
- Create a view with ajax and GET requests enabled
- Setup checkbox facets to associate with the new view
- Edit the view to add the newly created facets as filters through the facets views plugin integration
- Edit the view to enable better exposed filters, ideally with auto-submit enabled
- Save the view settings
- Test the view and request type by filtering with the facets and observing the network tab in your browser's debugger
- Verify you're seeing GET requests instead of POST
- Edit the view's ajax settings to disable GET requests
- Save the view settings
- Test the view with your network tab and verify you're now seeing POST requests (you may need to clear caches)
Updating issue summary to reference issue and Gitlab MR that removed GET support.
Slight tweaks to issue summary.
malik.kotob β created an issue.