Contrib.social

Remove deprecated code in BreadcrumbBuilder constructor

Open on Drupal.org →
Created on 6 October 2023, 9 months ago
Updated 18 March 2024, 3 months ago

Problem/Motivation

A `NULL` check was introduced in https://www.drupal.org/project/custom_breadcrumbs/issues/3358046 ✨ Drupal 10 compatibility fixes Needs review for the file url generator parameter to prevent those who extended the `BreadcrumbBuilder` before the addition of the file url generator parameter from encountering an error. These types of `NULL` checks for the file url generator exist in many places in core versions > 9.3 and < 10. They were all removed in versions >=10 → . The idea here is to follow core's pattern and remove the `NULL` check in a future release of custom_breadcrumbs that is only D10+ compatible.

Proposed resolution

Remove the fallbacks in the constructors.
Remove any NULLable default values and docblock references.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States malik.kotob

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024