- Issue created by @ashrafabed
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPractice
on the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
- If you have not done it yet, you should run
- Status changed to Needs work
about 1 year ago 4:06pm 14 September 2023 - 🇮🇳India vishal.kadam Mumbai
Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage.
This project is too small for us and it doesn't contain enough PHP code to really assess your skills as a developer.
Have you made any other contributions that we could instead review?
- Status changed to Needs review
about 1 year ago 5:14pm 14 September 2023 - 🇺🇸United States ashrafabed
If my skills as a developer need to be validated, one point of reference is my various Acquia certifications.
You can see them here: https://certification.acquia.com/?fname=ashraf&lname=abed&exam=AllAdditional relevant points:
- A talk I gave about Dependency injection: https://drupal.tv/index.php/external-video/2023-04-26/how-use-dependency...
- A talk I gave about caching: https://www.youtube.com/watch?v=6u4ziltJXFI
- A DrupalCon talk I gave about Fully & Progressively decoupled Drupal architectures: https://youtu.be/LvRbD8NAAcA?t=1035
- I teach a class on Drupal Architecture, including security
- I've performed security audits for many large Drupal projects
- I worked as a technical architect at Acquia for a few years
- I teach Drupal development, including classes on Security to senior developers (and others)Most of my development work is within private repositories. I'm hoping to use this project to jumpstart code contributions.
I hope this information provides confidence in my abilities as a module developer / maintainer. Please let me know.
Thank you for your time.
- 🇺🇸United States ashrafabed
Also, this is quite old, but one repository I worked on which has been made public is the WhiteHouse Petitions Drupal website: https://github.com/WhiteHouse/petitions/commits/7.x-3.x
The WhiteHouse project was security-conscious.
You can see various commits in the repository made by me (Ashraf Abed), such as:
- https://github.com/WhiteHouse/petitions/commit/4b38bb99759625d7e65085948...
- https://github.com/WhiteHouse/petitions/commit/f16c37c73eec802953e402d75...Thanks again.
- 🇺🇸United States malik.kotob
Hi @vishal.kadam! As a former student and current colleague of Ashraf's I can attest to his expertise in writing secure code and more broadly speaking as someone with significant professional Drupal development experience. I have personally been mentored and taught by Ashraf and use the skills I learned through his Drupal bootcamp on a daily basis in my role as a lead architect for Pantheon :)
I'm also a former architect at Acquia and CivicActions. Hope this helps with the approval process, looks like a great idea for a module!
- Status changed to Needs work
about 1 year ago 8:48pm 14 September 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
We review a project hosted on drupal.org to verify what the person who applies understands about writing secure code that follows the coding standards and correctly uses the Drupal API.
It is not possible to do this with a project that does not contain PHP code. - Status changed to Postponed
about 1 year ago 12:39pm 18 September 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
I am changing priority as per Issue priorities → .
- Status changed to Closed: won't fix
5 months ago 8:04am 1 July 2024 - 🇮🇳India rushiraval
This thread has been idle, in the needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.