jdleonard → credited ashrafabed → .
jdleonard → credited ashrafabed → .
As the original reporter of this issue, I only faced this issue on one project and I haven't been able to reproduce it since.
As far as I am concerned, I am OK with closing the issue unless someone else is still facing it and can provide more information.
ashrafabed → changed the visibility of the branch 2.x to hidden.
Drupal 10 had the optional argument (which was compatible with both 9 & 10):
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21Co...
Drupal 11 dropped the optional argument, making the optional argument break the form:
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21Co...
So in the pull request I'm about to push, I'll include increasing the core minimum compatibility
ashrafabed → created an issue.
I get the same error when using the OpenAI provider. Mentioning in case it might make sense to have e.g. a Trait shared between the modules. I haven't dug into the code for this yet.
ashrafabed → made their first commit to this issue’s fork.
“I had to use a debugger to figure in some cases why the configs changed and why it was unhappy about it.”
This (slack) comment was in relation to recipes defaulting to strict: true as part of a conversation about whether that should continue to be the case.
Based on my (brief) exposure to the issue via that conversation, I felt that “strict: true” was not the problem, the problem was the lack of visibility into whether all configs from a recipe were actually applied.
So I recommend displaying some sort of notice to explain how config was applied. For example, “Configuration for the following modules was/was not overridden because X”
I wish I could give a more specific recommendation, but I’m not prepared to at this time (would need to explore the issue more first)
ashrafabed → created an issue.
ashrafabed → created an issue.
jdleonard → credited ashrafabed → .
jdleonard → credited ashrafabed → .
Mentioned 'backup and migrate' module and the removal of the drush archive:restore command.
Good note @pgndrupal , looks like you're right, I'll update the page. Thanks for flagging that!
I am seeing the same issue on the latest (dev) version of xmlsitemap, but ONLY when rebuilding the sitemap via the UI.
So if you're experiencing this issue, consider rebuilding with drush:
drush xmlsitemap-rebuild
(Also sharing this in case it's helpful for others to reproduce the issue)
Update:
- MR #7 ( https://git.drupalcode.org/project/responsive_menus/-/merge_requests/7 ) resolves it for the 8.x-1.x branch
- MR#8 ( https://git.drupalcode.org/project/responsive_menus/-/merge_requests/8 ) resolves it for the 2.0.x branch
I submitted a merge request which resolves the issue:
https://git.drupalcode.org/project/responsive_menus/-/merge_requests/7
This was done as part of a Debug Academy Drupal training course to resolve an issue we encountered during our class project.
Changing Category from "Support request" to "Bug report" because this is a bug.
tekNorah → credited ashrafabed → .
This issue was originally created before the message was changed (the new wording was mentioned in #12), and the new wording addresses the "option 1" recommendation from comment #7.
Personally, I think this issue should be closed as duplicate (or as outdated). The related issues sufficiently address what this issue was created for.
Looks good! Here's my feedback:
1. I personally think the 'title' (Drupal Mentoring) being horizontal is easier to process (e.g. comment #10, "1.").
2. The Drupal logo is large (& looks great), but that takes away from the available space for the text. The original banner (comment #3) is easier to read, partly because it's not competing for space.
3. When I make banners without a QR code I usually regret it. IME people are more likely to visit links using if there is a QR code, so the lack of a QR code may reduce leads. If you decide to add a QR code, I recommend pointing it to a redirect so that you can track and/or change it in the future (e.g. https://drupal.org/core-mentoring-banner-qr , with it redirecting to https://drupal.org/core-mentoring)
4. The new designs look much more interesting and exciting than the original.
Very nice - thank you for working on this!
Replying too late to be helpful to you, but in case anyone finds this question on Google (as I did).
A "hook" is a PHP function which follows a specific naming convention.
An example of a hook which can be utilized by developers is hook_form_FORM_ID_alter()
A developer would create a PHP function whose name matches that of the hook, except they would:
- Replace the word "hook" with the name of their custom module (or custom theme)
- Replace any words which are in all-caps (in this instance, FORM_ID) with an appropriate value (in this instance, the form's ID)
The developer would place the PHP function they created inside of their custom module's MODULENAME.module file (or their theme's THEMENAME.theme file). For example, if their module was named debugacademy, they would place the hook in a file named debugacademy.module, located within the debugacademy/ module folder (typically modules/custom/debugacademy/debugacademy.module)
So if you were looking for a hook to update it, you would look in:
- Your custom modules' MODULENAME.module file
- Your custom theme's THEMENAME.theme file
Hopefully this is helpful to someone.
--
Ashraf Abed
Lead instructor, https://DebugAcademy.com
ashrafabed → created an issue.
laura.gates → credited ashrafabed → .
"What does this mean? Composer-installing it, but not Drupal-installing it?"
Exactly :)
The use case is a multisite codebase. All sites use the migrate module, but only some sites use Acquia Migrate. The error is thrown on the sites which don't use Acquia Migrate.
Thanks for the help!
Please review and merge, if possible. Thank you for your time.
The module includes a patch by URL. I'm attaching a new version of the patch so the same approach can be used.
ashrafabed → created an issue.
ashrafabed → created an issue.
Merged to dev.
ashrafabed → created an issue.
Merged to dev branch.
ashrafabed → created an issue.
Complete, unassigning.
Understood. I'll circle back on this then.
I agree with this addition, thank you both for reporting it and for submitting the PR. Merged to the dev branch for now.
Also, this is quite old, but one repository I worked on which has been made public is the WhiteHouse Petitions Drupal website: https://github.com/WhiteHouse/petitions/commits/7.x-3.x
The WhiteHouse project was security-conscious.
You can see various commits in the repository made by me (Ashraf Abed), such as:
- https://github.com/WhiteHouse/petitions/commit/4b38bb99759625d7e65085948...
- https://github.com/WhiteHouse/petitions/commit/f16c37c73eec802953e402d75...
Thanks again.
If my skills as a developer need to be validated, one point of reference is my various Acquia certifications.
You can see them here: https://certification.acquia.com/?fname=ashraf&lname=abed&exam=All
Additional relevant points:
- A talk I gave about Dependency injection: https://drupal.tv/index.php/external-video/2023-04-26/how-use-dependency...
- A talk I gave about caching: https://www.youtube.com/watch?v=6u4ziltJXFI
- A DrupalCon talk I gave about Fully & Progressively decoupled Drupal architectures: https://youtu.be/LvRbD8NAAcA?t=1035
- I teach a class on Drupal Architecture, including security
- I've performed security audits for many large Drupal projects
- I worked as a technical architect at Acquia for a few years
- I teach Drupal development, including classes on Security to senior developers (and others)
Most of my development work is within private repositories. I'm hoping to use this project to jumpstart code contributions.
I hope this information provides confidence in my abilities as a module developer / maintainer. Please let me know.
Thank you for your time.
ashrafabed → created an issue.
ashrafabed → created an issue. See original summary → .
You've always set a great example. I especially appreciate how welcoming you've been to people of all skillsets and backgrounds - you immediately treat people as equals and make them feel like friends. Thank you for everything.
volkswagenchick → credited ashrafabed → .
@richardb88 - This solution looks good! I submitted a follow up PR which modifies the syntax in your solution. It's a rebase of your work so that you're still credited with the solution.
https://git.drupalcode.org/issue/uswds_paragraphs-3267174/-/tree/3267174...
Marking your solution "Reviewed & tested" as my PR made no functional changes to your submission - only a syntax update.
ashrafabed → made their first commit to this issue’s fork.
The link said "Bootstrap 4" but it actually took us to a version which defaults to "Bootstrap 5".
State that Drupal core, the application, does not restrict itself to IPv4 requests.
Also applied #411 and it solved the issue for me. Thank you.