Account created on 26 March 2012, over 12 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

This issue was originally created before the message was changed (the new wording was mentioned in #12), and the new wording addresses the "option 1" recommendation from comment #7.

Personally, I think this issue should be closed as duplicate (or as outdated). The related issues sufficiently address what this issue was created for.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

Looks good! Here's my feedback:

1. I personally think the 'title' (Drupal Mentoring) being horizontal is easier to process (e.g. comment #10, "1.").

2. The Drupal logo is large (& looks great), but that takes away from the available space for the text. The original banner (comment #3) is easier to read, partly because it's not competing for space.

3. When I make banners without a QR code I usually regret it. IME people are more likely to visit links using if there is a QR code, so the lack of a QR code may reduce leads. If you decide to add a QR code, I recommend pointing it to a redirect so that you can track and/or change it in the future (e.g. https://drupal.org/core-mentoring-banner-qr , with it redirecting to https://drupal.org/core-mentoring)

4. The new designs look much more interesting and exciting than the original.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

Replying too late to be helpful to you, but in case anyone finds this question on Google (as I did).

A "hook" is a PHP function which follows a specific naming convention.

An example of a hook which can be utilized by developers is hook_form_FORM_ID_alter()

A developer would create a PHP function whose name matches that of the hook, except they would:
- Replace the word "hook" with the name of their custom module (or custom theme)
- Replace any words which are in all-caps (in this instance, FORM_ID) with an appropriate value (in this instance, the form's ID)

The developer would place the PHP function they created inside of their custom module's MODULENAME.module file (or their theme's THEMENAME.theme file). For example, if their module was named debugacademy, they would place the hook in a file named debugacademy.module, located within the debugacademy/ module folder (typically modules/custom/debugacademy/debugacademy.module)

So if you were looking for a hook to update it, you would look in:
- Your custom modules' MODULENAME.module file
- Your custom theme's THEMENAME.theme file

Hopefully this is helpful to someone.

--
Ashraf Abed
Lead instructor, https://DebugAcademy.com

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

"What does this mean? Composer-installing it, but not Drupal-installing it?"
Exactly :)

The use case is a multisite codebase. All sites use the migrate module, but only some sites use Acquia Migrate. The error is thrown on the sites which don't use Acquia Migrate.

Thanks for the help!

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

Please review and merge, if possible. Thank you for your time.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

The module includes a patch by URL. I'm attaching a new version of the patch so the same approach can be used.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

Merged to dev branch.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

ashrafabed β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

Complete, unassigning.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

Understood. I'll circle back on this then.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

I agree with this addition, thank you both for reporting it and for submitting the PR. Merged to the dev branch for now.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

Also, this is quite old, but one repository I worked on which has been made public is the WhiteHouse Petitions Drupal website: https://github.com/WhiteHouse/petitions/commits/7.x-3.x

The WhiteHouse project was security-conscious.

You can see various commits in the repository made by me (Ashraf Abed), such as:
- https://github.com/WhiteHouse/petitions/commit/4b38bb99759625d7e65085948...
- https://github.com/WhiteHouse/petitions/commit/f16c37c73eec802953e402d75...

Thanks again.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

If my skills as a developer need to be validated, one point of reference is my various Acquia certifications.
You can see them here: https://certification.acquia.com/?fname=ashraf&lname=abed&exam=All

Additional relevant points:
- A talk I gave about Dependency injection: https://drupal.tv/index.php/external-video/2023-04-26/how-use-dependency...
- A talk I gave about caching: https://www.youtube.com/watch?v=6u4ziltJXFI
- A DrupalCon talk I gave about Fully & Progressively decoupled Drupal architectures: https://youtu.be/LvRbD8NAAcA?t=1035
- I teach a class on Drupal Architecture, including security
- I've performed security audits for many large Drupal projects
- I worked as a technical architect at Acquia for a few years
- I teach Drupal development, including classes on Security to senior developers (and others)

Most of my development work is within private repositories. I'm hoping to use this project to jumpstart code contributions.

I hope this information provides confidence in my abilities as a module developer / maintainer. Please let me know.

Thank you for your time.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

You've always set a great example. I especially appreciate how welcoming you've been to people of all skillsets and backgrounds - you immediately treat people as equals and make them feel like friends. Thank you for everything.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

@richardb88 - This solution looks good! I submitted a follow up PR which modifies the syntax in your solution. It's a rebase of your work so that you're still credited with the solution.

https://git.drupalcode.org/issue/uswds_paragraphs-3267174/-/tree/3267174...

Marking your solution "Reviewed & tested" as my PR made no functional changes to your submission - only a syntax update.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

ashrafabed β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

The link said "Bootstrap 4" but it actually took us to a version which defaults to "Bootstrap 5".

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

State that Drupal core, the application, does not restrict itself to IPv4 requests.

πŸ‡ΊπŸ‡ΈUnited States ashrafabed

Also applied #411 and it solved the issue for me. Thank you.

Production build 0.69.0 2024