Acquia Migrate patch breaks migrations when Acquia Migrate not installed

The module includes a patch by URL. I'm attaching a new version of the patch so the same approach can be used.

Please review and merge, if possible. Thank you for your time.

Hiya, @ashrafabed! 😊 Thanks for taking the time to report this and providing a solution! 🙏

Downloading, but not installing, Acquia Migrate breaks migrations.

What does this mean? Composer-installing it, but not Drupal-installing it?

I'd like to understand why you'd install the AM:A module (and indeed have its core patches applied) using Composer, only to then not actually use it? 🤔😅

Still, I'll never oppose pragmatism and supporting more use cases, especially for anything migration-related! 😄

I'll help shepherd this MR to pass tests. It looks like the d.o GitLab template does not play nice with contrib modules 😬

"What does this mean? Composer-installing it, but not Drupal-installing it?"
Exactly :)

The use case is a multisite codebase. All sites use the migrate module, but only some sites use Acquia Migrate. The error is thrown on the sites which don't use Acquia Migrate.

Thanks for the help!

That makes sense. Drupal's migration system is unfortunately not designed to migrate a multisite at once — you have to do it site-per-site, which clearly you're very aware of. 👍😅

Next week I'll be at DrupalCon. The week after DrupalCon, I'll be working on lots of GitLab CI-related things. I'll tackle this then, because that's the only blocker here: getting it to pass on GitLab CI! Feel free to apply this patch for now, I promise that the 1.8.1 patch release will include this change 😊

Thanks again! 🙏

Later than planned, but will get to this next week — I've followed up on all issues by now :)

Last week was … the most hectic one of 2023. So, delayed by a week, but here I am!

After a whole saga with GitLab CI infrastructure/reliability/load, turns out we need zero changes to the CI setup.

Let's get this in at last!

Back when AM:A was closed source, there were some complications to the release process. But now … it's just a simple git checkout 1.8.x && git pull && git tag 1.8.1 && git push --tags 👍

https://www.drupal.org/project/acquia_migrate/releases/1.8.1 →

Very nice - thank you for working on this!

Automatically closed - issue fixed for 2 weeks with no activity.