🇮🇳India @rushiraval

Account created on 13 July 2023, 12 months ago
#

Recent comments

🇮🇳India rushiraval

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications , Application workflow , What to cover in an application review , and Tools to use for reviews .

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • Reviewers should show the output of a CLI tool only once per application.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues .

🇮🇳India rushiraval

The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user page for information. That page also tells you what "limitations" mean.

Since you haven't contributed yet here is a list of resources to help you on your journey:

🇮🇳India rushiraval

Hello @i-trokhanenko @apaderno

There two project at_tools and at_tools(version 2) are same

adpative_theme and at_theme are same.

So think this both can be merged or replaced as suggested by @mattbloomfield

🇮🇳India rushiraval

I am changing the issue priority as per issue priorities .

🇮🇳India rushiraval

Fix phpcs issue

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml image_scale_fill/

FILE: image_scale_fill/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 13 WARNINGS AFFECTING 13 LINES
------------------------------------------------------------------------
3 | WARNING | [ ] Line exceeds 80 characters; contains 420 characters
7 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
12 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
18 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
19 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
20 | WARNING | [ ] Line exceeds 80 characters; contains 137 characters
21 | WARNING | [ ] Line exceeds 80 characters; contains 161 characters
22 | WARNING | [ ] Line exceeds 80 characters; contains 141 characters
26 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
28 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
37 | WARNING | [ ] Line exceeds 80 characters; contains 138 characters
41 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
51 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
51 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: image_scale_fill/src/Plugin/ImageEffect/ScaleFillBackgroundEffect.php
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------
59 | WARNING | Line exceeds 80 characters; contains 81 characters
142 | WARNING | Line exceeds 80 characters; contains 95 characters
310 | WARNING | Line exceeds 80 characters; contains 88 characters
-------------------------------------------------------------------------------------------

FILE: image_scale_fill/image_scale_fill.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 90ms; Memory: 14MB

🇮🇳India rushiraval

Fix phpcs issues

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml calculation_fields/

FILE: calculation_fields/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 403 characters
9 | WARNING | Line exceeds 80 characters; contains 141 characters
16 | WARNING | Line exceeds 80 characters; contains 86 characters
21 | WARNING | Line exceeds 80 characters; contains 118 characters
24 | WARNING | Line exceeds 80 characters; contains 512 characters
31 | WARNING | Line exceeds 80 characters; contains 178 characters
50 | WARNING | Line exceeds 80 characters; contains 109 characters
53 | WARNING | Line exceeds 80 characters; contains 199 characters
72 | WARNING | Line exceeds 80 characters; contains 118 characters
74 | WARNING | Line exceeds 80 characters; contains 164 characters
----------------------------------------------------------------------

FILE: calculation_fields/calculation_fields.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------

FILE: calculation_fields/modules/calculation_fields_example/calculation_fields_example.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------

FILE: calculation_fields/modules/webform_calculation_fields/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 14 WARNINGS AFFECTING 14 LINES
--------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 395 characters
9 | WARNING | Line exceeds 80 characters; contains 178 characters
18 | WARNING | Line exceeds 80 characters; contains 111 characters
21 | WARNING | Line exceeds 80 characters; contains 118 characters
24 | WARNING | Line exceeds 80 characters; contains 325 characters
25 | WARNING | Line exceeds 80 characters; contains 81 characters
28 | WARNING | Line exceeds 80 characters; contains 213 characters
31 | WARNING | Line exceeds 80 characters; contains 216 characters
34 | WARNING | Line exceeds 80 characters; contains 177 characters
40 | WARNING | Line exceeds 80 characters; contains 223 characters
43 | WARNING | Line exceeds 80 characters; contains 223 characters
46 | WARNING | Line exceeds 80 characters; contains 134 characters
49 | WARNING | Line exceeds 80 characters; contains 271 characters
51 | WARNING | Line exceeds 80 characters; contains 161 characters
--------------------------------------------------------------------------------

FILE: calculation_fields/modules/webform_calculation_fields/webform_calculation_fields.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------

FILE: calculation_fields/modules/calculation_fields_example/webform_calculation_fields_examples.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------

Time: 165ms; Memory: 10MB

🇮🇳India rushiraval

@mattbloomfield We need to update summary and Description of this project page. Because its supports Drupal 10.

So user can view this in search view while searching module.

🇮🇳India rushiraval

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

🇮🇳India rushiraval

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,>DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the branch to review and the project name.

To the reviewers

Please read How to review security advisory coverage applications , Application workflow , What to cover in an application review , and Tools to use for reviews .

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications, even to leave a comment similar to the following one. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • It is also preferable to wait before using a CLI tool to report what needs to be changed, especially because the comment left from Code Review Administrators suggests to use PHP_CodeSniffer. Before that, manual reviews should be done.
  • Reviewers should not copy-paste the output of a CLI tool. They should use a CLI tool only once per application. When they do that, they should later verify the code has been correctly changed; this means, for example, that adding a documentation comment that is not correct just to avoid to get a warning/error is not a correct change that should be reported in a further comment.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues .

🇮🇳India rushiraval

I think you can continue with this application. You need to change description after you upload new module.
Then follow the comment #2.
When project is ready for for review then change status to "Needs Review"

🇮🇳India rushiraval

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,>DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the branch to review and the project name.

To the reviewers

Please read How to review security advisory coverage applications , Application workflow , What to cover in an application review , and Tools to use for reviews .

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications, even to leave a comment similar to the following one. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • It is also preferable to wait before using a CLI tool to report what needs to be changed, especially because the comment left from Code Review Administrators suggests to use PHP_CodeSniffer. Before that, manual reviews should be done.
  • Reviewers should not copy-paste the output of a CLI tool. They should use a CLI tool only once per application. When they do that, they should later verify the code has been correctly changed; this means, for example, that adding a documentation comment that is not correct just to avoid to get a warning/error is not a correct change that should be reported in a further comment.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues .

🇮🇳India rushiraval

@jandewit6 can you provide step to reproduce issue or share screenshot for issue.

🇮🇳India rushiraval

Since there is no activity on this issue since longtime. So closing it as outdated.

🇮🇳India rushiraval

I have reviewed this project findings in comment #3 and #6 are fixed. Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

🇮🇳India rushiraval

@tmotions
I have already reviewed both post. But there is not any meaningful contribution to community it is only link to contribution. This post you mentioning are committed by some other user. You can contribute community without confirmed role also.

🇮🇳India rushiraval

This user has already made one request which is clsoed. All post by user is not contributing to community. User has just copied URL of other user.

🇮🇳India rushiraval

Hello, and a warm welcome to the Drupal community!

You can contribute to drupal.org without having the role.

The 'confirmed' role is for users that contribute to this website. In this case, you've not contributed any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org.

You can add a comment to this issue to request a new review in order to get 'confirmed' or you will get that automatically.

Please visit the Become a confirmed user page for information.

Here is a list of resources that will assist you in making helpful contributions:

🇮🇳India rushiraval

I have applied patch #17 is working fine for me. I have attached screenshot for before and after patch.

🇮🇳India rushiraval

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

🇮🇳India rushiraval

Thanks @vishal.kadam. command added in comment.

🇮🇳India rushiraval

Fix the phpcs Error :

FILE: /sso_connector/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 13 WARNINGS AFFECTING 13 LINES
------------------------------------------------------------------------
3 | WARNING | [ ] Line exceeds 80 characters; contains 300 characters
22 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters
24 | WARNING | [ ] Line exceeds 80 characters; contains 150 characters
30 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
34 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
36 | WARNING | [ ] Line exceeds 80 characters; contains 123 characters
37 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
38 | WARNING | [ ] Line exceeds 80 characters; contains 201 characters
39 | WARNING | [ ] Line exceeds 80 characters; contains 138 characters
45 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
57 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
58 | WARNING | [ ] Line exceeds 80 characters; contains 186 characters
64 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
64 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: /sso_connector/sso_connector.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------------

FILE: /sso_connector/src/tests/src/Kernel/SsoTokenTest.php
--------------------------------------------------------------------------------
FOUND 10 ERRORS AND 2 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
11 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\KernelTests\KernelTestBase.
15 | WARNING | [x] Unused use statement
74 | ERROR | [x] Whitespace found at end of line
76 | ERROR | [x] Whitespace found at end of line
93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
94 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
95 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
96 | ERROR | [x] Expected 1 blank line before function; 0 found
98 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced
| | with use statements
139 | ERROR | [x] Expected 1 blank line after function; 2 found
142 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 1.17 secs; Memory: 10MB

🇮🇳India rushiraval

I think this project is too small for us and it doesn't contain enough PHP code. Senior Reviewer may review this.

🇮🇳India rushiraval

@voloda86

Please following step. It working fine for me

Install

  • composer require drupal/stable:^2.0
  • composer require 'drupal/at_tool:^2.0'

This will install

  • drupal/stable (2.0.0)
  • drupal/adaptivetheme (5.4.0)
  • drupal/at_tool (2.0.5)

then Enable AT Tool and AT Theme Generator from UI.

It works fine for me for on Drupal : 10.2.5 ( PHP : 8.2.7)

🇮🇳India rushiraval

I have confirmed your account based on your contribution for issue The display background of the name in the Media library module is white 🐛 The display background of the name in the Media library module is white Fixed

🇮🇳India rushiraval

mainis wrong names for branch. Release branch names always end with the literal .x as described in Release branches .

After updating as per comment #2 change status to Needs Review

🇮🇳India rushiraval

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,>DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the branch to review and the project name.

To the reviewers

Please read How to review security advisory coverage applications , Application workflow , What to cover in an application review , and Tools to use for reviews .

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications, even to leave a comment similar to the following one. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • It is also preferable to wait before using a CLI tool to report what needs to be changed, especially because the comment left from Code Review Administrators suggests to use PHP_CodeSniffer. Before that, manual reviews should be done.
  • Reviewers should not copy-paste the output of a CLI tool. They should use a CLI tool only once per application. When they do that, they should later verify the code has been correctly changed; this means, for example, that adding a documentation comment that is not correct just to avoid to get a warning/error is not a correct change that should be reported in a further comment.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues .

🇮🇳India rushiraval

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,>DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the branch to review and the project name.

To the reviewers

Please read How to review security advisory coverage applications , Application workflow , What to cover in an application review , and Tools to use for reviews .

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications, even to leave a comment similar to the following one. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • It is also preferable to wait before using a CLI tool to report what needs to be changed, especially because the comment left from Code Review Administrators suggests to use PHP_CodeSniffer. Before that, manual reviews should be done.
  • Reviewers should not copy-paste the output of a CLI tool. They should use a CLI tool only once per application. When they do that, they should later verify the code has been correctly changed; this means, for example, that adding a documentation comment that is not correct just to avoid to get a warning/error is not a correct change that should be reported in a further comment.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues .

🇮🇳India rushiraval

I have reviewed code. But I think there is not enough php code to review.

Senior reviewer may review code with this point.

🇮🇳India rushiraval

I am confirming your role based on your contribution to project (Personalized Content Dashboard)

🇮🇳India rushiraval

I have reviewed code. But I think there is not enough php code to review.

Senior reviewer may review code with this point.

🇮🇳India rushiraval

There was not any release when I have posted. Then contributor have created initial release. Thanks

now this issue may be marked fixed by contributor.

🇮🇳India rushiraval

I have reviewed code. Its looks clean. But I think there is not enough code to review.

Senior reviewer may review this further.

🇮🇳India rushiraval

Please solve the following phpcs Error

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/drupal-cache/

FILE: web/modules/contrib/drupal-cache/README.md
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
13 | WARNING | [ ] Line exceeds 80 characters; contains 632 characters
19 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
30 | WARNING | [ ] Line exceeds 80 characters; contains 253 characters
32 | WARNING | [ ] Line exceeds 80 characters; contains 420 characters
34 | WARNING | [ ] Line exceeds 80 characters; contains 422 characters
36 | WARNING | [ ] Line exceeds 80 characters; contains 220 characters
36 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: web/modules/contrib/drupal-cache/src/MomentoCacheBackendFactory.php
---------------------------------------------------------------------------------------------------------
FOUND 36 ERRORS AFFECTING 26 LINES
---------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [ ] Missing member variable doc comment
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [ ] Missing member variable doc comment
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Missing member variable doc comment
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [ ] Missing member variable doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [ ] Missing member variable doc comment
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [x] Missing function doc comment
20 | ERROR | [x] Expected 1 blank line before function; 2 found
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Missing function doc comment
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
36 | ERROR | [x] Missing function doc comment
37 | ERROR | [x] Opening brace should be on the same line as the declaration
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
49 | ERROR | [x] Expected 1 blank line after function; 0 found
50 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 31 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: web/modules/contrib/drupal-cache/src/MomentoCacheBackend.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 300 ERRORS AND 1 WARNING AFFECTING 251 LINES
-----------------------------------------------------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Component\Assertion\Inspector.
12 | ERROR | [x] Missing class doc comment
13 | ERROR | [x] Opening brace should be on the same line as the declaration
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [ ] Missing member variable doc comment
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [ ] Missing member variable doc comment
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [ ] Missing member variable doc comment
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [ ] Missing member variable doc comment
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [ ] Missing member variable doc comment
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [ ] Class property $MAX_TTL should use lowerCamel naming without underscores
23 | ERROR | [ ] Missing member variable doc comment
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [ ] Missing member variable doc comment
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [ ] Missing member variable doc comment
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
27 | ERROR | [x] Missing function doc comment
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
45 | ERROR | [x] Missing function doc comment
46 | ERROR | [x] Opening brace should be on the same line as the declaration
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Missing function doc comment
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Missing function doc comment
57 | ERROR | [x] Opening brace should be on the same line as the declaration
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
61 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
62 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
63 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
64 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
66 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
67 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
68 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
69 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
69 | ERROR | [ ] unserialize() is insecure unless allowed classes are limited. Use a safe format like JSON or use the
| | allowed_classes option.
71 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
72 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24
73 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
75 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
76 | ERROR | [x] Line indented incorrectly; expected 12 spaces, found 24
77 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
78 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
78 | ERROR | [x] Expected newline after closing brace
79 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found 20
81 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
83 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
84 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [x] Missing function doc comment
92 | ERROR | [x] Opening brace should be on the same line as the declaration
93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
96 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
100 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
101 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
101 | ERROR | [x] Expected newline after closing brace
102 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
108 | ERROR | [x] Missing function doc comment
109 | ERROR | [x] Opening brace should be on the same line as the declaration
110 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
113 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
119 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
127 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
130 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
131 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
132 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
134 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
136 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
137 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
138 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
141 | ERROR | [x] Missing function doc comment
142 | ERROR | [x] Opening brace should be on the same line as the declaration
143 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
145 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
146 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
148 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
150 | ERROR | [x] Expected newline after closing brace
151 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
153 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
155 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
155 | ERROR | [x] Missing function doc comment
156 | ERROR | [x] Opening brace should be on the same line as the declaration
157 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
158 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
159 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
161 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
162 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
164 | ERROR | [x] Missing function doc comment
165 | ERROR | [x] Opening brace should be on the same line as the declaration
166 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
167 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
171 | ERROR | [x] Missing function doc comment
172 | ERROR | [x] Opening brace should be on the same line as the declaration
173 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
174 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
175 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
176 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
178 | ERROR | [x] Missing function doc comment
179 | ERROR | [x] Opening brace should be on the same line as the declaration
180 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
181 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
182 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
183 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
184 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
185 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
186 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
187 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
190 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
190 | ERROR | [x] Missing function doc comment
191 | ERROR | [x] Opening brace should be on the same line as the declaration
192 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
194 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
195 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
197 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
197 | ERROR | [x] Missing function doc comment
198 | ERROR | [x] Opening brace should be on the same line as the declaration
199 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
200 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
201 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
204 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
204 | ERROR | [x] Missing function doc comment
205 | ERROR | [x] Opening brace should be on the same line as the declaration
206 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
207 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
208 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
209 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
211 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
211 | ERROR | [x] Missing function doc comment
212 | ERROR | [x] Opening brace should be on the same line as the declaration
213 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
214 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
215 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
217 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
217 | ERROR | [x] Missing function doc comment
218 | ERROR | [x] Opening brace should be on the same line as the declaration
219 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
221 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
222 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
223 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
224 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
226 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
227 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
228 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
229 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
230 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
231 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
232 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
233 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
235 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
236 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
237 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
238 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
239 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
239 | ERROR | [x] Expected newline after closing brace
240 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
241 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
242 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
243 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
244 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
245 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
246 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
248 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
248 | ERROR | [x] Missing function doc comment
249 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
249 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
| | parentheses
250 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
251 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
252 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
252 | ERROR | [x] Expected newline after closing brace
253 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
254 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
255 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
256 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
257 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
258 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
259 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
261 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
262 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
263 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
264 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
265 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
266 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
268 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
268 | ERROR | [x] Missing function doc comment
268 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
269 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
270 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
271 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
273 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
274 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
275 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
277 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
278 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
279 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
280 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
280 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
281 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
282 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
284 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
284 | ERROR | [x] Missing function doc comment
285 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
285 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
286 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
288 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
288 | ERROR | [x] Missing function doc comment
288 | ERROR | [x] Incorrect spacing between argument "$message" and equals sign; expected 1 but found 0
288 | ERROR | [x] Incorrect spacing between default value and equals sign for argument "$message"; expected 1 but found 0
288 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
289 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
290 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
291 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
292 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
292 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
293 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
294 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
295 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
296 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
298 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
298 | ERROR | [x] Missing function doc comment
299 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
300 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
301 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
302 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
305 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 16
306 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
306 | ERROR | [x] Expected newline after closing brace
307 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
308 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
308 | ERROR | [x] Expected newline after closing brace
309 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
310 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
311 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
312 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
314 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
314 | ERROR | [x] Missing function doc comment
315 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
316 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
317 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
318 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
321 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
322 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
322 | ERROR | [x] Expected 1 blank line after function; 0 found
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 290 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------

FILE: web/modules/contrib/drupal-cache/src/Client/MomentoClientFactory.php
----------------------------------------------------------------------------------------------------------
FOUND 39 ERRORS AFFECTING 29 LINES
----------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Missing class doc comment
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [ ] Missing member variable doc comment
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [ ] Missing member variable doc comment
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [ ] Missing member variable doc comment
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [ ] Missing member variable doc comment
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Missing function doc comment
18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
25 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Missing function doc comment
29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
41 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
41 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
42 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
42 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
43 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Expected 1 blank line after function; 0 found
47 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 35 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------

FILE: web/modules/contrib/drupal-cache/tests/src/Kernel/MomentoCacheBackendTest.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 48 ERRORS AND 9 WARNINGS AFFECTING 42 LINES
-----------------------------------------------------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [ ] Missing member variable doc comment
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Missing function doc comment
25 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
28 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
29 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
30 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
31 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
35 | ERROR | [x] Missing function doc comment
36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
38 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
40 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
57 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
57 | WARNING | [x] 'TODO: I'd like to get this working consistently, but it's failing intermittently. However,' should
| | match the format '@todo Fix problem X here.'
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | ERROR | [ ] Comment indentation error, expected only 1 spaces
59 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
60 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
62 | ERROR | [ ] Comment indentation error, expected only 2 spaces
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
63 | ERROR | [ ] Comment indentation error, expected only 4 spaces
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
68 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
69 | WARNING | [x] There must be no blank line following an inline comment
69 | WARNING | [ ] There must be no blank line following an inline comment
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
69 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
| | parentheses

🇮🇳India rushiraval

This module is for Drupal 9 and 10 but you requires php 7.4 in info.

Drupal 10 Requires php 8.1 and above. Please refer

https://www.drupal.org/docs/getting-started/system-requirements/overview

🇮🇳India rushiraval

@vishal.kadam thank for your guidance. It is noted for future review.

🇮🇳India rushiraval

solve the phpcs Error
phpcs --standard=Drupal,DrupalPractice web/modules/contrib/search_tracking/

FILE: web/modules/contrib/search_tracking/js/formData.js
-------------------------------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 11 LINES
-------------------------------------------------------------------------------------------
9 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
9 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
14 | ERROR | [x] Expected 1 space before "+"; 0 found
14 | ERROR | [x] Expected 1 space after "+"; 0 found
14 | ERROR | [x] Expected 1 space before "+"; 0 found
14 | ERROR | [x] Expected 1 space after "+"; 0 found
33 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
33 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
38 | ERROR | [x] Expected 1 space before "+"; 0 found
38 | ERROR | [x] Expected 1 space after "+"; 0 found
38 | ERROR | [x] Expected 1 space before "+"; 0 found
38 | ERROR | [x] Expected 1 space after "+"; 0 found
57 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
76 | ERROR | [x] Expected 1 newline at end of file; 8 found
79 | ERROR | [ ] More than 2 empty lines are not allowed
80 | ERROR | [ ] More than 2 empty lines are not allowed
81 | ERROR | [ ] More than 2 empty lines are not allowed
82 | ERROR | [ ] More than 2 empty lines are not allowed
83 | ERROR | [ ] More than 2 empty lines are not allowed
83 | ERROR | [x] Additional whitespace found at end of file
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------

FILE: web/modules/contrib/search_tracking/src/Form/SearchTrackingConfig.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 88 ERRORS AND 4 WARNINGS AFFECTING 73 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not begin with a file doc comment
5 | ERROR | [x] Doc comment short description must end with a full stop
12 | WARNING | [x] Unused use statement
12 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
16 | ERROR | [x] Function comment short description must start with exactly one space
16 | ERROR | [x] Doc comment short description must end with a full stop
19 | ERROR | [x] Opening brace should be on the same line as the declaration
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Missing function doc comment
22 | ERROR | [x] Opening brace should be on the same line as the declaration
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
24 | WARNING | [x] A comma should follow the last multiline array item. Found: 'search_tracking.settings'
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Opening brace should be on the same line as the declaration
33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
40 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
43 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
44 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
45 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
46 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
47 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
47 | ERROR | [ ] The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
47 | ERROR | [x] Short array syntax must be used to define arrays
47 | WARNING | [ ] #options values usually have to run through t() for translation
48 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
51 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
52 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
53 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
54 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
54 | ERROR | [x] Short array syntax must be used to define arrays
55 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
55 | ERROR | [x] Short array syntax must be used to define arrays
55 | ERROR | [x] Short array syntax must be used to define arrays
57 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
60 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
61 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
62 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
63 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
63 | ERROR | [x] Short array syntax must be used to define arrays
64 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
64 | ERROR | [x] Short array syntax must be used to define arrays
64 | ERROR | [x] Short array syntax must be used to define arrays
66 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
69 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
70 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
71 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
72 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
72 | ERROR | [x] Short array syntax must be used to define arrays
73 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
73 | ERROR | [x] Short array syntax must be used to define arrays
73 | ERROR | [x] Short array syntax must be used to define arrays
75 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
77 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
78 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
79 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
80 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
81 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
82 | ERROR | [x] Array indentation error, expected 14 spaces but found 16
83 | ERROR | [x] Array indentation error, expected 18 spaces but found 20
89 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | WARNING | [ ] Possible useless method overriding detected
99 | ERROR | [x] Opening brace should be on the same line as the declaration
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
101 | ERROR | [x] Expected 1 blank line after function; 0 found
102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Opening brace should be on the same line as the declaration
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
108 | ERROR | [x] Expected 1 blank line after function; 0 found
109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
113 | ERROR | [x] Opening brace should be on the same line as the declaration
114 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
115 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
116 | ERROR | [x] Object operator not indented correctly; expected 10 spaces but found 12
122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
122 | ERROR | [x] Expected 1 blank line after function; 0 found
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 89 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

FILE: web/modules/contrib/search_tracking/src/Controller/searchTrackingController.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AND 8 WARNINGS AFFECTING 16 LINES
------------------------------------------------------------------------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\JsonResponse.
8 | WARNING | [x] Unused use statement
8 | ERROR | [x] When importing a class with "use", do not include a leading \
9 | WARNING | [x] Unused use statement
14 | ERROR | [ ] Class name must begin with a capital letter
16 | ERROR | [x] Missing function doc comment
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
19 | ERROR | [x] Expected 1 space after IF keyword; 0 found
19 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
20 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
24 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
24 | ERROR | [x] Whitespace found at end of line
25 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
33 | ERROR | [ ] Public method name "searchTrackingController::search_tracking" is not in lowerCamel format
33 | ERROR | [x] Missing function doc comment
34 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
37 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
42 | ERROR | [x] Expected 1 blank line after function; 0 found
43 | ERROR | [x] The closing brace for the class must have an empty line before it
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

FILE: web/modules/contrib/search_tracking/search_tracking.views.inc
---------------------------------------------------------------------------------------------------
FOUND 31 ERRORS AFFECTING 30 LINES
---------------------------------------------------------------------------------------------------
4 | ERROR | [x] The second line in the file doc comment must be "@file"
5 | ERROR | [x] There must be no blank lines after the function comment
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
11 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
12 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
17 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
18 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
19 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
24 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
25 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
26 | ERROR | [x] Array indentation error, expected 10 spaces but found 8
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
30 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
31 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
32 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
33 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
35 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
36 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
37 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
39 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
40 | ERROR | [x] Array indentation error, expected 10 spaces but found 12
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Expected 1 newline at end of file; 2 found
44 | ERROR | [x] Whitespace found at end of line
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 31 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------

🇮🇳India rushiraval

Solve following phpcs Error

phpcs --standard=Drupal,DrupalPractice web/modules/contrib/fifo_lock/

FILE: web/modules/contrib/fifo_lock/src/FIFODatabaseLock.php
------------------------------------------------------------------------------------------------
FOUND 42 ERRORS AND 3 WARNINGS AFFECTING 44 LINES
------------------------------------------------------------------------------------------------
11 | ERROR | [x] Missing class doc comment
12 | ERROR | [x] Opening brace should be on the same line as the declaration
25 | ERROR | [ ] Missing member variable doc comment
34 | ERROR | [x] Opening brace should be on the same line as the declaration
41 | ERROR | [ ] Missing short description in doc comment
42 | ERROR | [ ] Missing parameter comment
43 | ERROR | [ ] Missing parameter comment
44 | ERROR | [ ] Description for the @return value is missing
48 | ERROR | [x] Opening brace should be on the same line as the declaration
56 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found
66 | ERROR | [x] Expected newline after closing brace
83 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found
95 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
111 | ERROR | [x] Expected newline after closing brace
115 | ERROR | [x] Expected newline after closing brace
122 | ERROR | [x] Expected newline after closing brace
127 | ERROR | [x] Expected newline after closing brace
136 | ERROR | [x] Expected 1 blank line after function; 2 found
139 | ERROR | [ ] Missing short description in doc comment
143 | ERROR | [x] Opening brace should be on the same line as the declaration
148 | ERROR | [x] Expected newline after closing brace
161 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found
167 | WARNING | [x] There must be no blank line following an inline comment
167 | WARNING | [ ] There must be no blank line following an inline comment
169 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found
178 | ERROR | [ ] Missing short description in doc comment
182 | ERROR | [x] Opening brace should be on the same line as the declaration
191 | ERROR | [x] Expected newline after closing brace
196 | ERROR | [x] Missing function doc comment
197 | ERROR | [x] Opening brace should be on the same line as the declaration
214 | ERROR | [x] Opening brace should be on the same line as the declaration
223 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
224 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
225 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
239 | ERROR | [ ] Missing parameter type
245 | ERROR | [x] Opening brace should be on the same line as the declaration
261 | ERROR | [x] Opening brace should be on the same line as the declaration
285 | ERROR | [x] Opening brace should be on the same line as the declaration
289 | ERROR | [x] Short array syntax must be used to define arrays
320 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
326 | ERROR | [x] Missing function doc comment
327 | ERROR | [x] Opening brace should be on the same line as the declaration
333 | ERROR | [x] Expected 1 space(s) after cast statement; 0 found
339 | ERROR | [x] Missing function doc comment
340 | ERROR | [x] Opening brace should be on the same line as the declaration
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 36 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

🇮🇳India rushiraval

Solve phpcs Error

phpcs --standard=Drupal,DrupalPractice web/modules/contrib/field_login/

FILE: web/modules/contrib/field_login/src/Form/FieldLoginSettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
74 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------

FILE: .../drupal104/web/modules/contrib/field_login/src/FieldLoginPluginManager.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
47 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
48 | WARNING | Unused variable $plugin_id.
64 | ERROR | Missing parameter comment
--------------------------------------------------------------------------------

FILE: web/modules/contrib/field_login/src/FieldLoginPluginManagerInterface.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
7 | ERROR | [x] Missing interface doc comment
9 | ERROR | [x] Missing function doc comment
11 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: web/modules/contrib/field_login/src/UserAuthDecorator.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is
| | Drupal\Core\DependencyInjection\DependencySerializationTrait.
55 | ERROR | [ ] Parameter $flood is not described in comment
55 | ERROR | [ ] Parameter $config_factory is not described in comment
63 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4
| | spaces
107 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: web/modules/contrib/field_login/src/UserVerificationInterface.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
5 | WARNING | [x] Unused use statement
9 | WARNING | [ ] The class short comment should describe what the class does
| | and not simply repeat the class name
15 | ERROR | [ ] Missing parameter comment
17 | ERROR | [x] Additional blank lines found at end of doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: web/modules/contrib/field_login/src/UserVerification.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
50 | ERROR | [x] Parameter comment must end with a full stop
52 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4
| | spaces
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: web/modules/contrib/field_login/field_login.api.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
13 | ERROR | Missing parameter type
--------------------------------------------------------------------------------

Time: 420ms; Memory: 10MB

🇮🇳India rushiraval

Rushikesh Raval made their first commit to this issue’s fork.

🇮🇳India rushiraval

I am changing the issue priority as per issue priorities .

🇮🇳India rushiraval

@cilefen I think it is not bug. It normal to reinitialize of variable on refresh. So no need for any code. But if @xandeadx needs to retain value then he may store value in session.

🇮🇳India rushiraval

Hello Team,

Can you please grant me access of co-maintainer so we will upgrade this module for Drupal 10.

Thanks

🇮🇳India rushiraval

I have reviewed the Patch #2. It changed the logo of twitter to X. so moving it RTBC+

🇮🇳India rushiraval

It may not be bug. When you refresh or reload page it will build form again. So form state will reinitialize.

🇮🇳India rushiraval

Please solve phpcs Error

FILE: jquery_form_validation/README.md
------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------
5 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
26 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------

FILE: query_form_validation.settings.yml
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
9 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------

FILE: jquery_form_validation/src/Form/TestValidationExampleForm.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
98 | WARNING | #options values usually have to run through t() for translation
-----------------------------------------------------------------------------------------------

FILE: jquery_form_validation/src/Form/JQueryValidationSettingsForm.php
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------
114 | WARNING | Unused variable $name_field.
118 | WARNING | Unused variable $name_field.
130 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
138 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
249 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
249 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------

🇮🇳India rushiraval

Sorry, Its my mistake I have check on beta version instead of dev. I found there is not phpcs error in dev Version.

🇮🇳India rushiraval

Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml mosparo_integration/

FILE: mosparo_integration/mosparo_integration.info.yml
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------

FILE: mosparo_integration/modules/mosparo_webform/mosparo_webform.info.yml
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------------------

FILE: mosparo_integration/modules/mosparo_contact/mosparo_contact.info.yml
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------------------

FILE: mosparo_integration/modules/mosparo_contact/src/Plugin/Field/FieldType/MosparoItem.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemBase.
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

FILE: mosparo_integration/modules/mosparo_contact/src/Plugin/Field/FieldWidget/MosparoWidget.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------
33 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
34 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------

FILE: mosparo_integration/modules/mosparo_captcha/mosparo_captcha.info.yml
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-------------------------------------------------------------------------------------------------------------------------

FILE: mosparo_integration/src/Form/MosparoConnectionForm.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityForm.
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------

FILE: mosparo_integration/src/Service/MosparoService.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
116 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------

FILE: .mosparo_integration/tests/src/Unit/Controller/MosparoConnectionListBuilderTest.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is
| | Drupal\Core\Entity\EntityStorageInterface.
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

FILE: .mosparo_integration/tests/src/Unit/Service/MosparoServiceTest.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
23 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Tests\UnitTestCase.
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

🇮🇳India rushiraval

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

  • If you have not done it yet, you should run phpcs --standard=Drupal,>DrupalPractice on the project, which alone fixes most of what reviewers would report.
  • For the time this application is open, only your commits are allowed.
  • The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; no other user will be able to opt projects into security advisory policy.
  • We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the branch to review and the project name.

To the reviewers

Please read How to review security advisory coverage applications , Application workflow , What to cover in an application review , and Tools to use for reviews .

The important notes are the following.

  • It is preferable to wait for a Code Review Administrator before commenting on newly created applications, even to leave a comment similar to the following one. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
  • It is also preferable to wait before using a CLI tool to report what needs to be changed, especially because the comment left from Code Review Administrators suggests to use PHP_CodeSniffer. Before that, manual reviews should be done.
  • Reviewers should not copy-paste the output of a CLI tool. They should use a CLI tool only once per application. When they do that, they should later verify the code has been correctly changed; this means, for example, that adding a documentation comment that is not correct just to avoid to get a warning/error is not a correct change that should be reported in a further comment.
  • It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues .

🇮🇳India rushiraval

Hello, and a warm welcome to the Drupal community!

You can contribute to drupal.org without having the role.

The 'confirmed' role is for users that contribute to this website. In this case, you've not contributed any content except 2 posts for account confirmation, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org.

You can add a comment to this issue to request a new review in order to get 'confirmed' or you will get that automatically.

Please visit the Become a confirmed user page for information.

Here is a list of resources that will assist you in making helpful contributions:

🇮🇳India rushiraval

Readme.md is as per Drupal Recommendation.

🇮🇳India rushiraval

Rushikesh Raval made their first commit to this issue’s fork.

Production build 0.69.0 2024