Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us; it does not contain enough PHP code to really assess your skills as a developer.
Do you have any other project hosted on drupal.org that we could instead review? It needs to have most of the commits (but preferably all the commits) done by you, in at least a branch.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
- For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
- Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
- For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
- Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Please go through comment #3 thoroughly.
Do not forgot to change status of the issue to Needs review when project is ready to review. in this queue only project status with 'Needs review' are reviewed.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
I am changing priority as per Issue priorities. →
I am changing priority as per Issue priorities. →
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.
Yes, it Passed Color Contrast for WCAG AA
I have manually checked color contrast for accessibility using wave tools (https://webaim.org/resources/contrastchecker/) current patch is not passing
WCAG AAA. I have attached screen herewith.
Reference : https://www.w3.org/WAI/WCAG21/Understanding/contrast-enhanced.html
It should be like this : gin-color-focus: rgb(8, 86, 176).
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
rushikesh raval → made their first commit to this issue’s fork.
rushikesh raval → made their first commit to this issue’s fork.
@dev.drupal.ln do not chage status to Reviewed & tested by the community.
Code Review Administrator will review the code.
@aneeshthankachan and @samberry it is not review of module working. It review of code.
if you want to review application in this queue then go through following which will help you to review application.
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
1.0 Wrong branch name
2.0 Fix phpcs issue
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
FILE: README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 85 characters
58 | WARNING | Line exceeds 80 characters; contains 105 characters
70 | WARNING | Line exceeds 80 characters; contains 199 characters
----------------------------------------------------------------------
FILE: views_regex_functions.views.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: .../views_regex_functions/src/Plugin/views/field/ViewsRegexFunctionsField.php
--------------------------------------------------------------------------------
FOUND 22 ERRORS AND 5 WARNINGS AFFECTING 23 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found
| | "\r\n"
15 | ERROR | [x] No space found before comment text; expected "// Following
| | is Used for Testing:" but found "//Following is Used for
| | Testing:"
16 | WARNING | [x] Unused use statement
16 | ERROR | [x] Use statements should be sorted alphabetically. The first
| | wrong one is Drupal\Core\Messenger\MessengerInterface.
110 | WARNING | [ ] Unused variable $fields.
114 | WARNING | [ ] Unused variable $fields.
117 | ERROR | [x] Line indented incorrectly; expected at least 4 spaces,
| | found 0
117 | ERROR | [x] 6 spaces found before inline comment; expected "//
| | '#prefix' => '
| | '
',"
173 | ERROR | [x] No space found before comment text; expected "// Make sure
| | that both the pattern and subject are not empty." but
| | found "//Make sure that both the pattern and subject are
| | not empty."
175 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10
178 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10
180 | ERROR | [x] Expected newline after closing brace
181 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE"
| | but found "false"
182 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10
188 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10
218 | WARNING | [ ] Unused private method markup()
235 | ERROR | [x] Expected 1 space after IF keyword; 0 found
236 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
238 | ERROR | [x] Expected 1 space after IF keyword; 0 found
239 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
250 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 10
254 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
254 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
256 | ERROR | [x] Expected 1 space after IF keyword; 0 found
257 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
260 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0
260 | ERROR | [x] 4 spaces found before inline comment; expected "//
| | \Drupal::messenger()->addMessage(json_encode($returnValue),
| | true);" but found "//
| | \Drupal::messenger()->addMessage(json_encode($returnValue),
| | true);"
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...views_regex_functions/config/schema/views_regex_functions.views.schema.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
19 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: views_regex_functions.info.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
Time: 88ms; Memory: 10MB
I am changing priority as per Issue priorities. →
Yes, Shortcuts is confusing with same option available in create. So We should remove duplication. But we have to provide shortcut module with CMS but it should not be installed. If any user require for any other shortcut then It may be useful.
@dev.drupal.ln Please do not change status to Needs Review for application which you have not created.
@dev.drupal.ln Please do not change status to Needs Review for application which you have not created.
@dev.drupal.ln Please do not change status to Needs Review for application which you have not created.
There is no need to create new branch. commit changes to 1.1.x only.
1.1 Remove "core: 8.x" from the .info.yml file
1.2 Fix PHP CS Error
PHPcs error attached in text file.
I am changing priority as per Issue priorities → .
It seems that this issue is related to drupal core. Not Related to Drupal CMS.
This issue also fixed. I have reviewed & Tested
@phenaproxima I have try with \Drupal::service('kernel')->invalidateContainer(); as per #33.
It working now.
so issue https://www.drupal.org/project/drupal_cms/issues/3492820 🐛 The "dashboard" parameter was not converted for the path Needs work is also fixed.
I have added \Drupal::cache('container')->deleteAll(); in drupal_cms_installer_uninstall_myself().
But now it throws some error. screenshot attached herewith
The website encountered an unexpected error. Try again later.
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "cache.container". in Symfony\Component\DependencyInjection\ContainerBuilder->getDefinition() (line 1042 of /var/www/html/vendor/symfony/dependency-injection/ContainerBuilder.php).
It working fine in Apache+PHP8.3+Postgresql on Linux. But in DDEV we need to use ddev drush cr after installation.
Yes, I have just post here this error for your information.
But still same issue continue.
Created project with RC2 still problem persist. It works after ddev drush cr. as per comment #27
I found two warning message in admin/reports/dblog
- The "field_block:node:page:field_content" block plugin was not found
- The "extra_field_block:node:page:links" block plugin was not found
have also executed ddev drush cr
It gives following output and after that refreshing page. Its working.
In EntityTypeManager.php line 139:
The "block" entity type does not exist.
Failed to run drush cr: exit status 1
When try to access other pages
The website encountered an unexpected error. Try again later.
Error: Call to a member function getPath() on null in drupal_cms_installer_theme_registry_alter() (line 286 of profiles/drupal_cms_installer/drupal_cms_installer.profile).
Drupal\Core\Extension\ModuleHandler->alter() (Line: 434)
Drupal\Core\Theme\Registry->build() (Line: 276)
Drupal\Core\Theme\Registry->get() (Line: 88)
Drupal\Core\Utility\ThemeRegistry->initializeRegistry() (Line: 69)
Drupal\Core\Utility\ThemeRegistry->__construct() (Line: 314)
Drupal\Core\Theme\Registry->getRuntime() (Line: 194)
Drupal\Core\Entity\EntityViewBuilder->getBuildDefaults() (Line: 157)
Drupal\Core\Entity\EntityViewBuilder->viewMultiple() (Line: 123)
Drupal\Core\Entity\EntityViewBuilder->view() (Line: 134)
Drupal\Core\Entity\Controller\EntityViewController->view()
call_user_func_array() (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext() (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709)
Drupal\Core\DrupalKernel->handle() (Line: 19)@phenaproxima I have Tried the step given in #22.
But still same issue.
I am still getting error after installation at
https://drupal-cms.ddev.site:8443/admin/dashboard/welcome?check_logged_in=1
The "dashboard" parameter was not converted for the path "/admin/dashboard/{dashboard}" (route name: "entity.dashboard.canonical")
@gautam_105@ You are not maintainer of [1.0.x] Rover. So you can not apply for this project. You can continue this application by opting for other project. Please go through comment #1 & #11
For the time this application is open, only your commits are allowed.
There is no need of .module files if it blank or no code.
so you can remove markdown_importer.module
This application created by @slajo on 26 Dec 2023 but then no activity by him on this thread. So I mark it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to set the issue status to Needs work or Needs review, depending on the current status of your code.
This thread has been idle, in the Postponed state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, Please so closing this application Closed(wont'fix) as per your comment #8.
Since I can't contribute to existing modules, I have started my own project and will update this ticket when I am done with it. Thank you
If this is incorrect, and you are still pursuing this application, then please feel free set the issue status to Needs work or Needs review, depending on the current status of your code.
1. main is a wrong name for a branch. Release branch names always end with the literal .x as described in
Release branches →
.
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
This application is by yogesh.k so only yogesh.k can reply and commit code till application approved.
Please go through all link in comment#4 for more detials.
1.0 Wrong Branch Name
2.0 Sovle phpcs Issue
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml vite_react_generator/
FILE: README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
66 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------
FILE: vite_react_generator.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
14 | ERROR | [x] Expected newline after closing brace
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: ...rupalwork/vite_react_generator/tests/src/Functional/_swc_testing/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 99 characters
--------------------------------------------------------------------------------
FILE: templates/babel/README.md
------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 99 characters
------------------------------------------------------------------------
FILE: templates/babel/src/index.css
----------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------
5 | ERROR | [x] Blank lines are not allowed in class definitions
9 | ERROR | [x] Blank lines are not allowed in class definitions
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------
FILE: templates/swc/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 99 characters
----------------------------------------------------------------------
FILE: templates/swc/src/index.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
5 | ERROR | [x] Blank lines are not allowed in class definitions
9 | ERROR | [x] Blank lines are not allowed in class definitions
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: CONTRIBUTING.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
55 | WARNING | Line exceeds 80 characters; contains 84 characters
77 | WARNING | Line exceeds 80 characters; contains 95 characters
83 | WARNING | Line exceeds 80 characters; contains 96 characters
89 | WARNING | Line exceeds 80 characters; contains 102 characters
95 | WARNING | Line exceeds 80 characters; contains 90 characters
101 | WARNING | Line exceeds 80 characters; contains 94 characters
106 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------
Time: 66ms; Memory: 10MB
hank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
1. 1.0.x-alpha is a wrong name for a branch. Release branch names always end with the literal .x as described in
Release branches →
.
1."main" is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → .
I am changing priority as per Issue priorities → .
1.0 Wrong Branch name
main is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → .
2.0 Fix phpcs issue
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,ymlpage_cache_vary/
FILE:page_cache_vary/src/VaryCacheContextCleanPass.php
------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------
9 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
11 | ERROR | [x] Doc comment star missing
13 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
21 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters
22 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
23 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------
FILE:page_cache_vary/src/StackMiddleware/PageCacheVary.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheableResponseInterface.
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
FILE:page_cache_vary/src/PageCacheVaryServiceProvider.php
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE:page_cache_vary/tests/Functional/PageCacheVaryTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\page_cache_vary_test\Cache\Context\CountryCacheContext.
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 63ms; Memory: 10MB
Solve phpcs issue
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonapi_advanced_permissions/
FILE: jsonapi_advanced_permissions/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 351 characters
35 | WARNING | Line exceeds 80 characters; contains 88 characters
41 | WARNING | Line exceeds 80 characters; contains 138 characters
----------------------------------------------------------------------
FILE: jsonapi_advanced_permissions//src/Form/JsonApiAdvancedPermissionsSettingsForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
62 | WARNING | Role::loadMultiple calls should be avoided in classes, use
| | dependency injection instead
--------------------------------------------------------------------------------
FILE: jsonapi_advanced_permissions//src/Permissions/JsonApiAdvancedPermissions.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
87 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------
Time: 46ms; Memory: 10MB
- The following points are just a start and don't necessarily encompass all of the changes that may be necessary
- A specific point may just be an example and may apply in other places
- A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; the single points aren't ordered, not even by importance
src/Form/TaxonomyTermConfirmationForm.php & TaxonomyTermReplaceForm.php
$target_term_id = base64_decode($request->query->get('target_term_id'));
$replacement_term_id = base64_decode($request->query->get('replacement_term_id'));
$total_nodes = base64_decode($request->query->get('total_nodes'));
$target_term = base64_decode($request->query->get('target_term'));
$replacement_term = base64_decode($request->query->get('replacement_term'));sanitize user inputted text
I reviewed you application. It Looks clean for me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
Please add the link to the project page in issue summary.
Please visit Apply for permission to opt into security advisory coverage →
@abhinesh project listed in #7 are already covered by the security advisory policy.
Please go through comment #6
If you have a project which matches those criteria, please edit the issue summary and change it to contains a short description of that project and a link to the project page.
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .
I am changing priority as per Issue priorities → .