[1.0.0] Accessibility tools

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
  Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
• Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1.1 Remove "core: 8.x" from the .info.yml file

1.2 Fix PHP CS Error

PHPcs error attached in text file.

1. main and develop are wrong names for a branch. Release branch names always end with the literal .x as described in Release branches → . The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.

2. FILE: README.md

README.md file should follow the content and formatting described in README.md template → .

3. FILE: a11y.module

/**
 * @file
 * Contains a11y.module.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

/**
 * Implements hook_preprocess_HOOK().
 */
function a11y_preprocess_a11y_template(&$variables) {

The description for this hook should also say for which hook it is implemented.

4. FILE: src/Form/A11yEditForm.php

  /**
   * {@inheritdoc}
   */
  public function __construct(

FILE: src/Form/A11yForm.php

  /**
   * {@inheritdoc}
   */
  public function __construct(

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

Hello, I have now fixed the indicated errors, and the pipelines for composer-lint, cspell, eslint, phpcs, phpstan, and stylelint are all OK.

I have also addressed the feedback provided in the comments. Everything is available in the 1.1.x branch. Is this good to go now? Should I create a 1.1.0 branch?

Thank you for your feedback and responses!

Updating to need review

There is no need to create new branch. commit changes to 1.1.x only.

change done

Review points 2, 3 and 4 are still pending from Comment #5 📌 [1.0.0] Accessibility tools Needs review .

Points 2, 3, and 4 are now fixed.

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

At the reviewers: Please note what the issue summary says. I re-wrote to make it clearer.

This module takes over the Accessibility toolkit → module to improve it in the near future. It is currently compatible with Drupal 10 and Drupal 11.

The first step is verifying there are significant changes between https://git.drupalcode.org/project/accesstools/-/tree/1.1.x?ref_type=heads and https://git.drupalcode.org/project/a11y/-/tree/2.x?ref_type=heads. The presence of the a11y directory is not significative, as it contains duplicate files.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

compatibility with Drupal 10 and 11. I will add more accessibility features later on.
I should delete the a11y directory if I understand correctly?

@anzelkiel Wait for a reviewer to report any change that should be done. It could also be the response is not Change these lines in these files.

ok thanks

@anzelkiel I would suggest that, if you think to add new features, this is the perfect time for doing it. The more code you write, more changes will the application get to be approved.

Hello, I was planning to work on the development this month and next month. With my job, I’m doing this in my free time, which is unfortunately quite limited. Should we wait before approving the application, or can the changes be made later on?