๐Ÿ‡ฎ๐Ÿ‡ณIndia @dev.drupal.ln

Account created on 9 December 2019, over 5 years ago
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

dev.drupal.ln โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

dev.drupal.ln โ†’ changed the visibility of the branch 3508421-compatibility-with-php to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

Hi claudiu.cristea,
Is their any update for me, Do you require anything from my end ?

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

Hi tbkot #tbkot, Patch doesn't work on latest commerce version

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

Hi Claudiu Cristea,

I have addressed the remarks you provided on the MR:
https://git.drupalcode.org/project/private_message/-/merge_requests/178

The changes have been pushed. Please review them when you have a chance.

I fetched and merged the latest 4.x branch, but it shows as already up-to-date. However, I am still encountering the PHPStan (next minor) issue in my MR pipeline.

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

Hi Claudiu Cristea,

I have created a new merge request: https://git.drupalcode.org/project/private_message/-/merge_requests/178 and updated it to target the 4.x branch as requested.

However, the pipeline fails due to a PHPStan (next minor) issue that is unrelated to the code I pushed. Could you please review it and let me know if anything is required from my end?

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

Hi @rkoller

I have created a patch to address the issue mentioned above. This patch enhances the browse token functionality by providing a filter option, allowing users to easily filter and locate specific tokens. Additionally, I am attaching a screenshot for reference. Please review once.

Thank you.

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

dev.drupal.ln โ†’ changed the visibility of the branch 3498388-add-support to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

dev.drupal.ln โ†’ changed the visibility of the branch 3497800-add-chatbox-block to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

Hello Vishal
I have fixed the all PHPCS issues. Could you please review again?

Thank you.

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

Hello Tim Rohaly

Thank you so much for your valuable feedback! I wanted to let you know that Iโ€™ve already successfully ported the Ubercart module to the stable version of Drupal 10 in one of my projects, and it's working great with all the core Ubercart functionality.

I completely understand your concerns, and I think it's a good idea to close the current issues. Let me close the issues that were raised by me and my team, and mark them as planned, so we can use that space to further discuss our goals and the way forward. This way, we can ensure weโ€™re all aligned and keep the conversation focused on the bigger picture.

Looking forward to collaborating more on this!

๐Ÿ‡ฎ๐Ÿ‡ณIndia dev.drupal.ln

dev.drupal.ln โ†’ made their first commit to this issueโ€™s fork.

Production build 0.71.5 2024