[1.0.x] Commerce imoje

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
  Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
• Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml commerce_imoje/

FILE: commerce_imoje/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 100 characters
 24 | WARNING | Line exceeds 80 characters; contains 120 characters
 32 | WARNING | Line exceeds 80 characters; contains 119 characters
----------------------------------------------------------------------

FILE: commerce_imoje/commerce_imoje.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
  5 | ERROR | [x] Missing function doc comment
 32 | ERROR | [x] Each PHP statement must be on a line by itself
 38 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: commerce_imoje/src/IPNHandler.php
------------------------------------------------------------------------------
FOUND 8 ERRORS AND 1 WARNING AFFECTING 8 LINES
------------------------------------------------------------------------------
  16 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Json.
  18 | ERROR   | [x] Missing class doc comment
  57 | ERROR   | [ ] Missing parameter comment
  58 | ERROR   | [ ] Missing parameter comment
 110 | ERROR   | [x] Case breaking statements must be followed by a single blank line
 115 | ERROR   | [x] Case breaking statements must be followed by a single blank line
 150 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 150 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 152 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: commerce_imoje/src/BlikPaymentFormBuilderInterface.php
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
 8 | ERROR | [x] Missing interface doc comment
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: commerce_imoje/src/Plugin/Commerce/PaymentGateway/ImojeRedirect.php
------------------------------------------------------------------------------
FOUND 1 ERROR AND 17 WARNINGS AFFECTING 17 LINES
------------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
  6 | WARNING | [x] Unused use statement
  7 | WARNING | [x] Unused use statement
  8 | WARNING | [x] Unused use statement
  9 | WARNING | [x] Unused use statement
 10 | WARNING | [x] Unused use statement
 11 | WARNING | [x] Unused use statement
 13 | WARNING | [x] Unused use statement
 14 | WARNING | [x] Unused use statement
 15 | WARNING | [x] Unused use statement
 15 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\DependencyInjection\ContainerInterface.
 16 | WARNING | [x] Unused use statement
 17 | WARNING | [x] Unused use statement
 18 | WARNING | [x] Unused use statement
 19 | WARNING | [x] Unused use statement
 20 | WARNING | [x] Unused use statement
 21 | WARNING | [x] Unused use statement
 67 | WARNING | [ ] #description values usually have to run through t() for translation
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: commerce_imoje/src/Plugin/Commerce/PaymentGateway/ImojeOffsitePaymentGatewayBase.php
------------------------------------------------------------------------------
FOUND 24 ERRORS AND 2 WARNINGS AFFECTING 26 LINES
------------------------------------------------------------------------------
  15 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\DependencyInjection\ContainerInterface.
  23 | ERROR   | [x] Missing class doc comment
  46 | ERROR   | [x] Missing function doc comment
 199 | ERROR   | [ ] Missing parameter comment
 201 | ERROR   | [ ] Description for the @return value is missing
 213 | ERROR   | [ ] Missing parameter comment
 215 | ERROR   | [ ] Description for the @return value is missing
 227 | ERROR   | [ ] Missing parameter comment
 228 | ERROR   | [ ] Missing parameter comment
 229 | ERROR   | [ ] Missing parameter comment
 231 | ERROR   | [ ] Description for the @return value is missing
 242 | ERROR   | [ ] Missing parameter comment
 243 | ERROR   | [ ] Missing parameter comment
 245 | ERROR   | [ ] Description for the @return value is missing
 280 | WARNING | [ ] Exceptions should not be translated
 285 | WARNING | [ ] Exceptions should not be translated
 301 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
 303 | ERROR   | [ ] Missing parameter comment
 305 | ERROR   | [ ] Description for the @return value is missing
 306 | ERROR   | [x] Separate the @return and @throws sections by a blank line.
 318 | ERROR   | [ ] Missing parameter comment
 320 | ERROR   | [ ] Description for the @return value is missing
 321 | ERROR   | [x] Separate the @return and @throws sections by a blank line.
 331 | ERROR   | [ ] Missing parameter comment
 333 | ERROR   | [ ] Description for the @return value is missing
 334 | ERROR   | [x] Separate the @return and @throws sections by a blank line.
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: commerce_imoje/src/ImojeGatewayInterface.php
------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------
 15 | ERROR | [x] Missing function doc comment
 17 | ERROR | [x] Missing function doc comment
 19 | ERROR | [x] Missing function doc comment
 21 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: commerce_imoje/src/BlikPaymentFormBuilder.php
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------
 38 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 40 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 47 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------

FILE: commerce_imoje/src/Event/ImojePaymentEvent.php
------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------
  6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\commerce\EventBase.
 35 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
 37 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: commerce_imoje/src/IPNHandlerInterface.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 12 | ERROR | Parameter $service_key is not described in comment
 12 | ERROR | Parameter $payment_gateway_id is not described in comment
--------------------------------------------------------------------------------

FILE: commerce_imoje/src/PluginForm/ImojeRedirect/ImojePaymentForm.php
------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------
  9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerInjectionInterface.
 26 | ERROR   | [ ] Missing parameter comment
 67 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: commerce_imoje/src/ImojeGateway.php
------------------------------------------------------------------------------
FOUND 16 ERRORS AND 3 WARNINGS AFFECTING 18 LINES
------------------------------------------------------------------------------
  14 | WARNING | [x] Unused use statement
  15 | WARNING | [x] Unused use statement
  16 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Json.
  18 | WARNING | [x] Unused use statement
  20 | ERROR   | [x] Missing class doc comment
  56 | ERROR   | [ ] Parameter $time is not described in comment
  63 | ERROR   | [ ] Missing parameter comment
  72 | ERROR   | [ ] Missing short description in doc comment
  85 | ERROR   | [ ] Missing short description in doc comment
  86 | ERROR   | [ ] @throws comment must be on the next line
 117 | ERROR   | [ ] Missing short description in doc comment
 118 | ERROR   | [ ] @throws comment must be on the next line
 138 | ERROR   | [ ] Missing parameter comment
 139 | ERROR   | [ ] Missing parameter comment
 140 | ERROR   | [ ] Missing parameter comment
 141 | ERROR   | [ ] Missing parameter comment
 143 | ERROR   | [ ] Description for the @return value is missing
 144 | ERROR   | [x] Separate the @return and @throws sections by a blank line.
 144 | ERROR   | [ ] @throws comment must be on the next line
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: commerce_imoje/src/Controller/BlikController.php
------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------
  51 | ERROR | Missing parameter comment
  80 | ERROR | Return type "\Symfony\Component\HttpFoundation\JsonResponse A response." must not contain spaces
 114 | ERROR | Return type "\Symfony\Component\HttpFoundation\JsonResponse A response." must not contain spaces
------------------------------------------------------------------------------

FILE: commerce_imoje/css/blik-payment-form.css
------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------
 65 | ERROR | [x] Opening brace should be the last content on the line
 65 | ERROR | [x] Closing brace of class definition must be on new line
 66 | ERROR | [x] Opening brace should be the last content on the line
 66 | ERROR | [x] Closing brace of class definition must be on new line
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

@dev.drupal.ln Please do not change status to Needs Review for application which you have not created.

rushikesh raval is correct: Without the applicant changing the status from Active to Needs review, we do not change the issue status. It also means this application is not ready for review.

I am also changing the priority, since the applicant has not posted any comment.