- Issue created by @dev.drupal.ln
- Merge request !171Chatbox block feature added to private message module → (Open) created by Unnamed author
- 🇮🇳India dev.drupal.ln
dev.drupal.ln → changed the visibility of the branch 3497800-add-chatbox-block to hidden.
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
Thank you for the contribution. It seems an interesting new feature. We've opened the 4.x branch for development and all new stuff should be filled against 4.x. Please change the MR base branch.
- Merge request !178Add Chatbox Block to Private Message Module: https://www.drupal.org/project/private_message/issues/3497800 → (Open) created by Unnamed author
- 🇮🇳India dev.drupal.ln
Hi Claudiu Cristea,
I have created a new merge request: https://git.drupalcode.org/project/private_message/-/merge_requests/178 and updated it to target the 4.x branch as requested.
However, the pipeline fails due to a PHPStan (next minor) issue that is unrelated to the code I pushed. Could you please review it and let me know if anything is required from my end?
- 🇷🇴Romania claudiu.cristea Arad 🇷🇴
The PHPStan failure is weird because that was fixed in 4.x maybe you should rebase on top of a fresh 4.x. I left some remarks but didn't install to see how it works. Will do a 2nd round after. Also this needs tests.
- 🇮🇳India dev.drupal.ln
Hi Claudiu Cristea,
I have addressed the remarks you provided on the MR:
https://git.drupalcode.org/project/private_message/-/merge_requests/178The changes have been pushed. Please review them when you have a chance.
I fetched and merged the latest 4.x branch, but it shows as already up-to-date. However, I am still encountering the PHPStan (next minor) issue in my MR pipeline.
- 🇮🇳India dev.drupal.ln
Hi claudiu.cristea,
Is their any update for me, Do you require anything from my end ? - 🇷🇴Romania claudiu.cristea Arad 🇷🇴
See my latest review in MR. It also needs test