[1.0.x] Webform Integration Pipedrive

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
  Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
• Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml webform_pipedrive/

FILE: webform_pipedrive/webform_pipedrive.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user can change something - rather than "access
   |         | administration pages" which is about viewing but not changing configurations.
--------------------------------------------------------------------------------

FILE: webform_pipedrive/src/Plugin/WebformHandler/WebformPipedrive.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
  75 | WARNING | Unused variable $webform_settings.
 187 | WARNING | Unused variable $user_field_mapping.
 209 | WARNING | Unused variable $webform_name.
 210 | WARNING | Unused variable $webform_uuid.
 212 | WARNING | Unused variable $submission_uuid.
 251 | WARNING | Unused variable $mapping_options.
--------------------------------------------------------------------------------

FILE: webform_pipedrive/src/Service/PipedriveIntegration.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
 22 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 42 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 55 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 84 | WARNING | Unused variable $datadeal.
 91 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------

FILE: webform_pipedrive/src/Service/GetAccessToken.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 20 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------

2. FILE: webform_pipedrive.info.yml

core: 8.x
core_version_requirement: ^9 || ^10

If the module is compatible with all Drupal 8 versions, include ^8 in core_version_requirement; otherwise, remove core: 8.x.

3. FILE: webform_pipedrive.module

/**
 * @file
 * Webform Integration with Pipedrive module.
 *
 * This module integrates the Drupal Webform module with Pipedrive CRM.
 * It automates the submission of Webform data to Pipedrive, providing
 * seamless synchronization between Drupal forms and Pipedrive records.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

Hello Vishal
I have fixed the all PHPCS issues. Could you please review again?

Thank you.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

@dev.drupal.ln do not chage status to Reviewed & tested by the community.

Code Review Administrator will review the code.

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that does not follow the coding standards, contains possible security issue, or does not correctly use the Drupal API
• The single review points are not ordered, not even by importance

src/Plugin/WebformHandler/WebformPipedrive.php

    catch (RequestException $e) {
      \Drupal::logger('webform_pipedrive')->error('Error fetching Pipedrive fields: ' . $e->getMessage());
    }

The $message parameter passed to the LoggerInterface methods must be a literal string that uses placeholders. It's not a translatable string returned from t() or $this->t(), or a string concatenation.

Any dependency must be injected using the dependency injection container, except in the case the dependency is used only from static methods.

Hi @avpaderno

I have fixed the above mentioned issue. Please review once.

Thank you.

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank the dedicated reviewers as well.

If the account is not a shared account, may you add your first and last name to the user account?

Hello @avpaderno
I have updated my First Name and Last Name.
Thank you