[1.0.x] Twig casings

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage.

This project is too small for us and it doesn't contain enough PHP code to really assess your skills as a developer.

Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.

Currently, I don't have any other modules. This is my first. If I create any more I'll update this issue.

I have added another maintainer who maintains a great deal more modules than I and has been a backend Drupal developer for 16+ years.
See: https://www.drupal.org/u/barry_fisher →

Are the security advisory coverage applications per module or per maintainer? If per maintainer how can we tell if a maintainer can opt projects in?

The security advisory coverage application process assigns the required role to the applicant, enabling them to opt projects into security advisory coverage.

To verify if a user has the necessary role to opt a module into security advisory coverage, navigate to the user profile and check for the section labeled "Can opt projects into security advisory coverage."

I have added another maintainer who maintains a great deal more modules than I and has been a backend Drupal developer for 16+ years.

Adding as maintainer somebody who is already able to opt projects into security advisory coverage does not speed up this application, which aims to give you the drupal.org role necessary to opt projects you create or for which you can edit the project node into security advisory coverage and make commits.
It does not actually change the fact the project used for this application does not have enough PHP code to be reviewed, which is the reason the status is now Needs work.

Thank you very much for the clarification. The other maintainer is able to opt projects in to security advisory coverage so is it worth closing this issue and I'll open another one when I have another contrib project with more PHP for you to review?

[I]s it worth closing this issue and I'll open another one when I have another contrib project with more PHP for you to review?

We can do so, yes.

Just popping back and marking this as needs review again.

I've recently created another module which contains more PHP than this one. See: https://www.drupal.org/project/twig_placeholders →

I've been following all the standards and hopefully this will give you a better idea of my capabilities. I've been working with Drupal for over 10 years professionally for a variety of enterprise organisations and am now looking to be more involved in the contrib space and being able to opt projects in to security advisory coverage will be a major step. For example I have an application open to maintain / co-maintain an abandoned module: https://www.drupal.org/project/projectownership/issues/3514042 💬 Offering to co-maintain Media Entity Link Active and have recently become a co-maintainer on the nodeaccess project https://www.drupal.org/project/nodeaccess → .

In addition to this I've also added additional commits to the twig_casings project and intend to continue updating and supporting these modules for many years to come.

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

Thank you so much! I really appreciate your review.

Automatically closed - issue fixed for 2 weeks with no activity.