Webform Booking Calendar - Request for Security Advisory Coverage

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

Updating to need review

1. main is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → . The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.

2. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml webform_booking_calendar/

FILE: webform_booking_calendar/webform_booking_calendar.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------

FILE: webform_booking_calendar/README.md
------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------
  4 | WARNING | Line exceeds 80 characters; contains 137 characters
  9 | WARNING | Line exceeds 80 characters; contains 88 characters
 21 | WARNING | Line exceeds 80 characters; contains 92 characters
 22 | WARNING | Line exceeds 80 characters; contains 85 characters
 23 | WARNING | Line exceeds 80 characters; contains 95 characters
 24 | WARNING | Line exceeds 80 characters; contains 89 characters
------------------------------------------------------------------------

FILE: webform_booking_calendar/webform_booking_calendar.permissions.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 4 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: webform_booking_calendar/src/Plugin/Block/WebformBookingCalendarBlock.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------------
   7 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Database.
  80 | ERROR   | [x] Expected newline after closing brace
  96 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 134 | ERROR   | [x] Expected 1 blank line after function; 0 found
 135 | ERROR   | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: webform_booking_calendar/src/Controller/WebformBookingCalendarController.php
--------------------------------------------------------------------------------
FOUND 9 ERRORS AND 9 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------------
  24 | WARNING | [ ] There must be no blank line following an inline comment
  24 | ERROR   | [x] Comments may not appear after statements
  36 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
  47 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  50 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
  50 | WARNING | [ ] There must be no blank line following an inline comment
  50 | ERROR   | [x] Comments may not appear after statements
  69 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
  69 | ERROR   | [x] Comments may not appear after statements
  70 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
  70 | ERROR   | [x] Comments may not appear after statements
  88 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 102 | ERROR   | [x] Expected newline after closing brace
 110 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
 110 | ERROR   | [x] Comments may not appear after statements
 118 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 127 | ERROR   | [x] Expected 1 blank line after function; 0 found
 128 | ERROR   | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: webform_booking_calendar/webform_booking_calendar.routing.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: webform_booking_calendar/css/webform_booking_calendar.css
--------------------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 15 LINES
--------------------------------------------------------------------------------
  32 | ERROR | [ ] More than 2 empty lines are not allowed
  33 | ERROR | [ ] More than 2 empty lines are not allowed
  34 | ERROR | [x] Expected 1 space before opening brace of class definition; 2 found
  35 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  40 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
  40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
  45 | ERROR | [x] CSS colours must be defined in lowercase; expected #5f19eb but found #5F19EB
  86 | ERROR | [x] CSS colours must be defined in lowercase; expected #4caf50 but found #4CAF50
 186 | ERROR | [x] CSS colours must be defined in lowercase; expected #4caf50 but found #4CAF50
 200 | ERROR | [ ] More than 2 empty lines are not allowed
 201 | ERROR | [ ] More than 2 empty lines are not allowed
 202 | ERROR | [ ] More than 2 empty lines are not allowed
 203 | ERROR | [ ] More than 2 empty lines are not allowed
 204 | ERROR | [ ] More than 2 empty lines are not allowed
 205 | ERROR | [ ] More than 2 empty lines are not allowed
 206 | ERROR | [ ] More than 2 empty lines are not allowed
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------