[1.x-dev] Orange Dam

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Remember to change status, when the project is ready for review, as in this queue Active means Don't review yet the project I am using for this application.

Needs review is the status used when the project is ready for review.

For these applications, we need a project where, in at least the branch used for the application, most of the commits (if not all the commits) have been done from the user who applies.
The purpose of these applications is reviewing a project to understand what the person who applies understands about writing secure code that follows the Drupal coding standards and correctly uses the Drupal API, not what all the project maintainers collectively understand about those points.

This application can only continue with a project (and a branch) where all the commits (or the majority of the commits) have been done by you.

> Needs review is the status used when the project is ready for review.

Yes, @vishal.kadam, thank you for the reminder, but I kept it as `active` on purpose since I wasn't ready for this be reviewed. Thanks again :)

@apaderno I wasn't really ready for this to be reviewed, but your feedback is valuable. Unfortunately, the majority of my commits are not visible in gitlab since they were made in github before the module was contributed.

Since I can't contribute to existing modules, I have started my own project and will update this ticket when I am done with it. Thank you.

This thread has been idle, in the Postponed state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, Please close the application if are not pursuing this application
If this is incorrect, and you are still pursuing this application, then please feel free set the issue status to Needs work or Needs review, depending on the current status of your code.

I am changing priority as per Issue priorities → .

This thread has been idle, in the Postponed state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, Please so closing this application Closed(wont'fix) as per your comment #8.

Since I can't contribute to existing modules, I have started my own project and will update this ticket when I am done with it. Thank you

If this is incorrect, and you are still pursuing this application, then please feel free set the issue status to Needs work or Needs review, depending on the current status of your code.