View Pager Control

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Please go through comment #3 thoroughly.

Do not forgot to change status of the issue to Needs review when project is ready to review. in this queue only project status with 'Needs review' are reviewed.

Please also notice that, for the time this application is open (its status is not Fixed), the only allowed commits are from you.

Thank you for your information. You can review the project now

1. FILE: view_pager_plugin.info.yml

package: Custom

This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.

2. FILE: README.md

The README file is missing the required sections → , including Project name, and Requirements.

@Vishal Kadam → Thank you for reviewing. I have made the changes you mentioned on this branch (1.0.x).

Rest seems fine to me.

Let’s wait for other reviewers and Code Review Administrator to take a look and if everything goes fine, you will get the role.

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that does not follow the coding standards, contains possible security issue, or does not correctly use the Drupal API
• The single review points are not ordered, not even by importance

src/Plugin/views/pager/PageControl.php

    $form['items_first_page'] = [
      '#title' => $this->t('Items For The First Page'),
      '#type' => 'number',
      '#min' => 0,
      '#description' => $this->t('Set Items Per Page'),
      '#default_value' => $this->options['items_first_page'],
    ];

Titles and descriptions must not use title case: Only the first word is capitalized; the other ones are capitalized only if they are written capitalized in English (proper nouns, acronyms, registered trademarks that require to be written capitalized).

    return $this->formatPlural(
      $this->options['items_first_page'],
      ' First Page @count items , Other Pages @other items',
      'Paged,  First Page @count items , Other Page @other items ',
      [
        '@count' => $this->options['items_first_page'],
        '@other' => $this->options['items_other_page'],
      ]
    );

It is not clear why the plural string should start with 'Paged ,' but the singular string does not start with 'Paged ,'.
In English, there is just a space after a comma, not before a comma (which is instead used in French), and what follows the comma is not a capitalized word (except in the case that word is a proper noun, for example).
In that string, there are two values which could be singular or plural, so the string should be split in two parts which are both passed to $this->formatPlural().

  /**
   * Update global paging info.
   *
   * This is called after the count query has been run to set the total
   * items available and to update the current page if the requested
   * page is out of range.
   */
  public function updatePageInfo() {
    $this->pagerManager->createPager($this->getPagerTotal(), 1, $this->options['id']);
  }

Methods inherited from the parent class do not repeat the document comment.

@avpaderno → Thank you for reviewing. I have made the changes you mentioned on this branch (1.0.x).

Please let me know if I need to do anything else. All is fine; please change the RTBC status. Thank you.

    return $this->formatPlural(
      $this->options['items_first_page'],
      ' First Page @count items , Other Pages @other items',
      'Paged,  First Page @count items , Other Page @other items ',
      [
        '@count' => $this->options['items_first_page'],
        '@other' => $this->options['items_other_page'],
      ]
    );

It is not clear why the plural string should start with 'Paged ,' but the singular string does not start with 'Paged ,'.
In English, there is just a space after a comma, not before a comma (which is instead used in French), and what follows the comma is not a capitalized word (except in the case that word is a proper noun, for example).
In that string, there are two values which could be singular or plural, so the string should be split in two parts which are both passed to $this->formatPlural().

    return $this->t('Pages info: First page @count; other pages @other.',
      [
        '@count' => $this->formatPlural(
          $this->options['items_first_page'],
          $this->options['items_first_page'] . ' item',
          $this->options['items_first_page'] . ' items'
        ),
        '@other' => $this->formatPlural(
          $this->options['items_other_page'],
          $this->options['items_other_page'] . ' item',
          $this->options['items_other_page'] . ' items'
        ),
      ]
    );

$this->options['items_other_page'] . ' item' and $this->options['items_other_page'] . ' items' are not translatable strings.

@avpaderno → Thank you for reviewing. I have made the changes you mentioned on this branch (1.0.x).

@avpaderno → Thank you for the clarification! I understand that the second and third arguments for $this->formatPlural() should be literal strings rather than concatenated strings or values returned by a function/method. I will ensure to use explicit strings like '1 item' for the singular form and '@count items' for the plural form in my implementation.

If you have any further suggestions or examples, please let me know!

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank the dedicated reviewers as well.