- Issue created by @mtbrkrgn
- 🇮🇹Italy apaderno Brescia, 🇮🇹
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
- For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage. - Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
- 🇮🇳India vishal.kadam Mumbai
1.0.0is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → . - 🇮🇳India rushiraval
Solve phpcs issue
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonapi_advanced_permissions/
FILE: jsonapi_advanced_permissions/README.md ---------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------- 5 | WARNING | Line exceeds 80 characters; contains 351 characters 35 | WARNING | Line exceeds 80 characters; contains 88 characters 41 | WARNING | Line exceeds 80 characters; contains 138 characters ---------------------------------------------------------------------- FILE: jsonapi_advanced_permissions//src/Form/JsonApiAdvancedPermissionsSettingsForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 62 | WARNING | Role::loadMultiple calls should be avoided in classes, use | | dependency injection instead -------------------------------------------------------------------------------- FILE: jsonapi_advanced_permissions//src/Permissions/JsonApiAdvancedPermissions.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 87 | WARNING | t() calls should be avoided in classes, use | | \Drupal\Core\StringTranslation\StringTranslationTrait and | | $this->t() instead -------------------------------------------------------------------------------- Time: 46ms; Memory: 10MB - 🇹🇷Turkey mtbrkrgn
Hello there,
Switched to use DI instead of class call, modified the translation method to trait and edited the README.md file so the phpcs, phpstan doesn't give error/warnings anymore.