[1.0.0] RankCrew

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
• For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
• Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

I have executed the pipeline, and fix all the phpcs but for the phpstan, I don't know how to solve it, because i'm using the Rest Ressource, and the injection are not managed by my module, so I have still those 2 errors:
Line src/Plugin/rest/resource/RankcrewResource.php
------ ----------------------------------------------------------------------
119 \Drupal calls should be avoided in classes, use dependency injection
instead
199 \Drupal calls should be avoided in classes, use dependency injection
instead

Do you know how I can inject them ?

Thanks

I have skip the phpstan, and create the new release, it should be good now, also for Drupal 7 if you want to check it aslo

Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us; it does not contain enough PHP code to really assess your skills as a developer.

Do you have any other project hosted on drupal.org that we could instead review? It needs to have most of the commits (but preferably all the commits) done by you, in at least a branch.

Hello,

No I don't have any other project in Drupal, but I have other custom modules, that I can upload here, let me know if it's ok like that, see the zip in attachement code.zip and the commits.zip

I'm a Drupal developer since almost 17 years, I started with Drupal 5 or 6, and now Drupal 11, I built alone a lot of website, the most recent are :
https://www.allnews.ch/
https://camps.apolline.art/

Thanks

We only review projects with commits from the person who created the application.

Yes it's the case, I made the project and I made the commits, did you look the attachements? or do you need more projects?

We do not look at the code posted as attachment. We need a project link for a project for which you made commits.
https://www.drupal.org/project/rankcrew → does not contain enough PHP code, as a previous comment reported.