[1.0.x] Vite + React Single Directory Component (SDC) Generator

hank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1.0 Wrong Branch Name

2.0 Sovle phpcs Issue

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml  vite_react_generator/

FILE: README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 66 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------


FILE: vite_react_generator.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
 14 | ERROR | [x] Expected newline after closing brace
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...rupalwork/vite_react_generator/tests/src/Functional/_swc_testing/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 99 characters
--------------------------------------------------------------------------------


FILE: templates/babel/README.md
------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 99 characters
------------------------------------------------------------------------


FILE: templates/babel/src/index.css
----------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------
 5 | ERROR | [x] Blank lines are not allowed in class definitions
 9 | ERROR | [x] Blank lines are not allowed in class definitions
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------


FILE: templates/swc/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 3 | WARNING | Line exceeds 80 characters; contains 99 characters
----------------------------------------------------------------------


FILE: templates/swc/src/index.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 5 | ERROR | [x] Blank lines are not allowed in class definitions
 9 | ERROR | [x] Blank lines are not allowed in class definitions
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: CONTRIBUTING.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
  55 | WARNING | Line exceeds 80 characters; contains 84 characters
  77 | WARNING | Line exceeds 80 characters; contains 95 characters
  83 | WARNING | Line exceeds 80 characters; contains 96 characters
  89 | WARNING | Line exceeds 80 characters; contains 102 characters
  95 | WARNING | Line exceeds 80 characters; contains 90 characters
 101 | WARNING | Line exceeds 80 characters; contains 94 characters
 106 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------

Time: 66ms; Memory: 10MB

Lint fixes have been merged into vite_react_generator/1.0.x.

Remote branch vite_react_generator/feature/2.0.x/drupal11-support has been removed. It was a "work in progress" to capture documentation changes necessary for future support of Drupal 11 in a 2.0.x version. Drupal 11 support is out of scope at this time.

perrygeorget → changed the visibility of the branch projectapplications-3490962 to hidden.

1. FILE: vite_react_generator.info.yml

package: Custom

This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.

2. FILE: vite_react_generator.module

/**
 * @file
 * Module hook vite_react_generator implementations.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

Thank you for your feedback.

Changes have been made to address the identified issues.

diff --git a/vite_react_generator.info.yml b/vite_react_generator.info.yml
index cefbf83..564b0db 100644
--- a/vite_react_generator.info.yml
+++ b/vite_react_generator.info.yml
@@ -1,5 +1,5 @@
-name: 'vite_react_generator'
+name: 'Vite React App Generator'
 type: module
 description: 'Generates Vite + React apps.'
-package: Custom
+package: Development
 core_version_requirement: ^9 || ^10
diff --git a/vite_react_generator.module b/vite_react_generator.module
index 20ed8fb..49cf180 100644
--- a/vite_react_generator.module
+++ b/vite_react_generator.module
@@ -2,7 +2,7 @@
 
 /**
  * @file
- * Module hook vite_react_generator implementations.
+ * Hook implementations for the Vite React App Generator module.
  */
 
 use Drupal\Component\Utility\Html;

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

Thank you @vishal.kadam