[1.x] - Image processor webp

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. master is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → .

2. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml image_processor_webp/

FILE: image_processor_webp/image_processor_webp.routing.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: image_processor_webp/image_processor_webp.module
------------------------------------------------------------------------------
FOUND 21 ERRORS AFFECTING 21 LINES
------------------------------------------------------------------------------
  1 | ERROR | [x] Missing file doc comment
 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 11 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 12 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 13 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 14 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 15 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 16 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 17 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 18 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 19 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 20 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 21 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 22 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 24 | ERROR | [x] Case breaking statement indented incorrectly; expected 10 spaces, found 12
 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 36 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: image_processor_webp/image_processor_webp.info.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

Thanks for your review.

I've fixed the codestyles, branch name and implement .gitlabCI.

master is a wrong name for a branch, which needs to be deleted.

The master branch is not used on drupal.org. drupal.org plans to support a main branch, but the support is not yet complete. For now, the branch names must follow what is reported in Release branches → .

I've deleted the master branch and keep only one 1.0.x

Rest seems fine to me.

Let’s wait for other reviewers and Code Review Administrator to take a look and if everything goes fine, you will get the role.

I am changing priority as per Issue priorities → .