[1.0.x] Confirm Unpublish

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

As a side note, since this project is new, it is not possible to opt into security advisory policy for this project before 10 days are passed.

1. FILE: composer.json

    "require": {
      "drupal/core": "^9 || ^10 || ^11"
    },

FILE: confirm_unpublish.info.yml

core_version_requirement: ^9 || ^10 || ^11

A new project should not declare itself compatible with a Drupal release that is no longer supported. No site should be using Drupal 8 nor Drupal 9, and people should not be encouraged to use those Drupal releases.

2. FILE: confirm_unpublish.module

/**
 * Implements hook_form_FORM_ID_alter().
 */
function confirm_unpublish_form_node_form_alter(&$form, FormStateInterface $form_state, $form_id) {

The description for that hook should also say for which form that hook is implemented, either by indicating that with the name of the class that implements the form (namespace included) or the form ID (which is usually indicated by getFormId()).

Thanks everyone for the quick response and I apologize for my delayed response.

@avpaderno I wasn't aware there was a 10 day waiting period. I appreciate the info and I'm definitely ok with that.

@ vishal.kadam thank you for pointing out those issue. I have corrected the core version requirements in the .info and just removed it from composer since it didn't need to be there. I also updated the comment to be more specific in the .module file. All changes are current in the 1.x branch.

I did work this evening to get all the CI passing as well. Ran into some issues with that but got them all straightened out. Please let me know if there is anything else I need to do.

Setting back to needs review.