- Issue created by @malik.kotob
- πΊπΈUnited States malik.kotob
Updating issue summary to reference issue and Gitlab MR that removed GET support.
- @malikkotob opened merge request.
- πΊπΈUnited States malik.kotob
Merge request is up!
Requires contrib modules to test:
- Facets
- better exposed filters
- views_ajax_get
Testing steps:
- Enable the required contrib modules
- Login to your site
- Visit /admin/structure/views/settings/advanced and enable views_ajax_get extender
- Create a view with ajax and GET requests enabled
- Setup checkbox facets to associate with the new view
- Edit the view to add the newly created facets as filters through the facets views plugin integration
- Edit the view to enable better exposed filters, ideally with auto-submit enabled
- Save the view settings
- Test the view and request type by filtering with the facets and observing the network tab in your browser's debugger
- Verify you're seeing GET requests instead of POST
- Edit the view's ajax settings to disable GET requests
- Save the view settings
- Test the view with your network tab and verify you're now seeing POST requests (you may need to clear caches)
- Status changed to Needs review
over 1 year ago 6:48pm 23 February 2023 - Status changed to Needs work
over 1 year ago 8:43am 3 March 2023 - π©πͺGermany mkalkbrenner π©πͺ
I think we should create a sub-module facets_ajax that has dependencies to better_exposed_filters and views_ajax_get.
In facets itself we should throw an exception if a view uses ajax and a facet gets rendered without facets_ajax beeing active. - π¬π§United Kingdom catch
π Allow AJAX to use GET requests Fixed landed in 10.1.x, is some of this needed to work with the core change now?
- πΊπΈUnited States smustgrave
Changing this to a bug now.
When using facets 3.0.x all ajax paginations are now broken.
Steps to reproduce
Install facets
Edit admin/content view by enabling ajax
Add enough content or edit view to trigger pagination.
Pagination no longer works.Can also be seen in the media library widget.
Applying the MR resolved the problem.
- π¬π§United Kingdom catch
Updating the issue title. The RouteAlterSubscriber probably won't be necessary to add support for views_ajax_get any more (since that module should hopefully be deprecated from 10.1.x onwards), but most/all the rest of the changes look generic to support AJAX GET requests at all.
@mkalkbrenner I guess the approach should change now since the views_ajax_get is redundant?
Then again how would we handle BC for < 10.1.x sites?
- π©πͺGermany mkalkbrenner π©πͺ
- Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Waiting for branch to pass - π³π±Netherlands pjotr van der horst
This patch contains the current state of the merge request. See "Patches from drupal.org merge request URLs are dangerous?" for more information.
- π³π±Netherlands pjotr van der horst
I've used a filename that was not websafe. My bad. I can't delete my previous comment. here is the patch with the commit hash as filename.
This patch contains the current state of the merge request. See "Patches from drupal.org merge request URLs are dangerous?" for more information.