- Issue created by @nicxvan
- Status changed to Needs review
8 months ago 1:53am 24 April 2024 - 🇮🇳India onkararun
@nicxvan kindly please provide which tool you are using to check the deprecated code. so i can review this code.
- 🇮🇳India onkararun
Hi nicxvan,
I have Verified and tested MR !7683 3443049-remove-deprecations-in on Drupal Version 11.x-dev & PHP Version 8.3
Testing Steps:-
1). Install Drupal 11.x version.
2). /projects/drupal/ git remote add drupal-3443049 https://git.drupalcode.org/issue/drupal-3443049.git
3). git fetch drupal-3443049
4). git checkout -b '3443049-remove-deprecations-in' --track drupal-3443049/'3443049-remove-deprecations-in'
5). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/lib/Drupal/Core/Installer/Form/SiteConfigureForm.php to check the that deprecated code removed or not and check the site afer thatTesting result:
MR !7683 3443049-remove-deprecations-in issue is fixed
Moved the issue to RTBC ++ - Status changed to RTBC
8 months ago 11:24am 24 April 2024 - 🇺🇸United States nicxvan
Thanks for your review Arun.k!
I've addressed @longwave's comment so this should be ready again.
-
longwave →
committed a879c616 on 11.x
Issue #3443049 by nicxvan, Arun.k: Remove deprecations in...
-
longwave →
committed a879c616 on 11.x
- Issue was unassigned.
- Status changed to Fixed
8 months ago 3:06pm 24 April 2024 -
alexpott →
committed 46a2192b on 11.x
Revert "Issue #3443049 by nicxvan, Arun.k: Remove deprecations in...
-
alexpott →
committed 46a2192b on 11.x
- Status changed to Postponed
8 months ago 4:27pm 24 April 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Thanks @nicxvan and @Arun.k for working on this. Just going to postpone it on 🐛 Super user access policy and the installer Fixed as multiple branching that issue will be painful.
- 🇺🇸United States nicxvan
Ah, I apologize, I didn't realize that would cause a conflict.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@nicxvan you have nothing to apologize for - I'm just trying to land a bigger piece of work that needs 🐛 Super user access policy and the installer Fixed - once that lands this one will have a little more to do :)
- Status changed to Needs work
8 months ago 11:50am 25 April 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
🐛 Super user access policy and the installer Fixed is in... this now has more to do. Thanks for your patience @nicxvan
- Status changed to Needs review
8 months ago 1:12pm 25 April 2024 - 🇺🇸United States nicxvan
No worries, that would have made 🐛 Super user access policy and the installer Fixed more painful.
This should be ready now!
- Status changed to Needs work
8 months ago 1:43pm 25 April 2024 - Status changed to Needs review
8 months ago 2:15pm 25 April 2024 - Status changed to RTBC
8 months ago 2:20pm 25 April 2024 - Status changed to Fixed
8 months ago 2:46pm 25 April 2024 -
alexpott →
committed 7886a7ed on 11.x
Issue #3443049 by nicxvan, Arun.k, longwave, alexpott: Remove...
-
alexpott →
committed 7886a7ed on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.