- Issue created by @quietone
- Status changed to Needs review
8 months ago 3:45am 19 April 2024 - Status changed to RTBC
8 months ago 12:42pm 19 April 2024 - 🇺🇸United States smustgrave
Some notes that may not matter
> Don't see a mention of transliteration or tua-body-scroll-block but they're in the vendor folder
> 📌 [jQuery 4] jquery-form is unmaintained and not jQuery 4 compatible, fork it into core Fixed we forked jquery.form into the repo. Do we need an entry in the COPYRIGHT File?Everything else seems correct and I don't know if my points are valid for holding so will go ahead and mark.
- 🇳🇿New Zealand quietone
Some notes that may not matter
What does this mean here?forked jquery.form into the repo. Do we need an entry in the COPYRIGHT File?
In the MR the copyright file can be expanded and then the existing entry for 'jQuery Form' can be seen.
- Status changed to Needs review
8 months ago 9:20am 21 April 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Added a review comment to the MR... the text change seems to repeat the copyright year - not sure why we should do that.
- Status changed to RTBC
8 months ago 7:25am 26 April 2024 - 🇮🇳India onkararun
@alexpott I have tested and Verified MR !7608 3413657-update-copyright.txt-for on Drupal Version 11.x-dev & PHP Version 8.3
Testing Steps:-
1). Install Drupal 11.x version.
2). /projects/drupal/ git remote add drupal-3413657 https://git.drupalcode.org/issue/drupal-3413657.git
3). git fetch drupal-3413657
4). git checkout -b '3413657-update-copyright.txt-for' --track drupal-3413657/'3413657-update-copyright.txt-for'
5). use vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml core/COPYRIGHT.txt
to check the file, it showing no nothing just warning on line 29 i.e 'Line exceeds 80 characters; contains 102 characters'. So if we enter on the line like below then it removes the warning
'JavaScript Cookie - Copyright (c) 2018 Copyright 2018 Klaus Hartl,
Fagner Brack, GitHub Contributors'
Otherwise everything is fine
Testing result:
MR !7608 3413657-update-copyright.txt-for is fixed
Moved the issue to RTBC ++ - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Discussed with @quietone - going to backport this so changing title.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Backported to 10.2.x so all new releases will have correct copyright text.
Committed and pushed 66de90c6b5 to 11.x and 48561d14e6 to 10.3.x and 42c3b3a073 to 10.2.x. Thanks!
-
alexpott →
committed 42c3b3a0 on 10.2.x
Issue #3413657 by quietone: Update COPYRIGHT.txt for 2024 (cherry...
-
alexpott →
committed 42c3b3a0 on 10.2.x
-
alexpott →
committed 48561d14 on 10.3.x
Issue #3413657 by quietone: Update COPYRIGHT.txt for 2024 (cherry...
-
alexpott →
committed 48561d14 on 10.3.x
- Status changed to Fixed
8 months ago 9:19am 26 April 2024 -
alexpott →
committed 66de90c6 on 11.x
Issue #3413657 by quietone: Update COPYRIGHT.txt for 2024
-
alexpott →
committed 66de90c6 on 11.x
-
alexpott →
committed 66de90c6 on 11.0.x
Issue #3413657 by quietone: Update COPYRIGHT.txt for 2024
-
alexpott →
committed 66de90c6 on 11.0.x