- Issue created by @Lus
- Merge request !6768Issue #3423775: Add "description" key to the SymfonyMailer.php โ (Open) created by Lus
- Issue was unassigned.
- Status changed to Needs review
10 months ago 11:18am 26 February 2024 - Assigned to shreyal999
- Status changed to Needs work
10 months ago 1:07pm 26 February 2024 The Needs Review Queue Bot โ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- ๐บ๐ธUnited States xjm
Thanks for your work on this issue.
Merge request should always be filed against 11.x to start. Fixes will be backported to the appropriate Drupal branches when the issue is committed.
Sometimes the easiest thing to do is to close the old MRs and create a new one based on 11.x. That will bring us closer to passing automated tests Thanks!
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ made their first commit to this issueโs fork.
- Merge request !85953423775: Add description key in the SymfonyMailer.php โ (Open) created by samit.310@gmail.com
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 10.2.x to hidden.
- ๐ฎ๐ณIndia samit.310@gmail.com
samit.310@gmail.com โ changed the visibility of the branch 3423775-symfony-mailer-description to hidden.
- Issue was unassigned.
- Status changed to Needs review
6 months ago 4:48am 1 July 2024 - ๐ฎ๐ณIndia onkararun
@samit.310@gmail.com i have checked and verified merge request MR !6768 and found that there is no warning showing.
steps to check
1. Install 11.x-dev on DDEV v1.22.6 and php 8.3.0
2. using git remote add drupal-3423775 https://git.drupalcode.org/issue/drupal-3423775.git
3. git fetch drupal-3423775
4. and then git checkout -b '3423775-symfony-mailer-description-fix' --track drupal-3423775/'3423775-symfony-mailer-description-fix'
5. install webform module and create form for mail sent.
6. Found no warning after going to branch 3423775-symfony-mailer-description-fix - Status changed to RTBC
6 months ago 9:29am 1 July 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Description is not a required argument in \Drupal\Core\Mail\Attribute\Mail ... I feel this is something that should be fixed in webform.
All it needs to do is something like
if ($mail_module_name || $mail_plugin_id) { $t_args = [ '@module' => $mail_module_name, '@plugin_id' => $mail_plugin_id, ]; $requirements['webform_email'] = [ 'title' => t('Webform: HTML email support'), 'value' => ($mail_module_name) ? t('Provided by the @module module.', $t_args) : t('Provided by the @plugin_id mail plugin.', $t_args), 'severity' => REQUIREMENT_OK, ]; if ($mail_plugin_definition) { $requirements['webform_email']['description'] = $mail_plugin_definition['label'] . // Add the description if available. isset($mail_plugin_definition['description']) ? ': ' . $mail_plugin_definition['description'] : ''; } }
Note the use of formattable markup is unnecessary here - we can rely on Twig's auto-escape.
- Status changed to Needs work
5 months ago 11:24am 11 July 2024