In Drupal 11 this results in a TypeError on the status report page:
TypeError: Drupal\Component\Utility\Html::escape(): Argument #1 ($text) must be of type string, null given, called in /app/web/core/lib/Drupal/Component/Render/FormattableMarkup.php on line 238 in Drupal\Component\Utility\Html::escape() (line 431 of /app/web/core/lib/Drupal/Component/Utility/Html.php).
Adding a patch.
Opened a merge request based on #53.
artis.bajars → made their first commit to this issue’s fork.
@jurgenhaas with the latest 3.x-dev version of Gin and the patch from 📌 Improve sticky actions implementation Active the throbber is kinda restored. However is this the intended look for it?
artis.bajars → created an issue.
Opened a merge request based on patch #17.
artis.bajars → made their first commit to this issue’s fork.
Tested with Elasticsearch Helper 8.1.0, Elasticsearch 8.15.2 on Drupal 10.3.5. Good to go.
Tested and confirmed working. The index is now always refreshed before querying which prevents the issue.
maijs → credited artis.bajars → .
artis.bajars → created an issue.
artis.bajars → created an issue.
artis.bajars → made their first commit to this issue’s fork.
Noticed that when loading the template dialog form in CKEditor the template definitions get cached in the first language they're loaded under and do not update when switching languages. This switches to using a language-specific cache key in the CkeditorTemplatePluginManager
Couple of small additions:
- Changed the schema type of the
descriptionfield totextin order to make it translatable - Added an update hook to install the entity type definition as noted in #57 ✨ CKEditor 5 support for Content Templates Needs review
The issue around psr/http-message still remains even after https://github.com/thephpleague/oauth2-server/releases/tag/8.5.2 was released. Internally league/oauth2-server requires league/uri: ^6.7 which in turn has a dependency on psr/http-message: ^1.0.1 so the only way to install the module is still using composer require -W which forces a downgrade.
Would the (hopefully) upcoming 10.1.x core update of CKEditor 5 to v39 that apparently adds empty element support help here in making the "invisible anchor" placeholders editable? https://www.drupal.org/project/drupal/issues/3377562 📌 Update CKEditor 5 to 39.0.0 Fixed
Issue persists in the 4.x branch as well. Uploading a rerolled patch.
Adding patch
artis.bajars → created an issue.
Had some time to look at this closer and it seems to me that all that's needed to prevent the uri from jumping from the entity: to the internal: schema is to try and load the entity translation from context. Please review.
One thing that neither the bvedad/ckeditor5-anchor nor the forked northernco/ckeditor5-anchor-drupal libraries currently support is empty anchor link elements in the form of <a id="myAnchor" name="myAnchor"></a>. Our editors have created most of the anchor links like this and upgrading to the CKEditor5 version of anchor_link in this form would make them uneditable.
Previously this was supported by Fakeobjects I guess, but since there is no equivalent for CKEditor5 what are our options here?
artis.bajars → created an issue.
artis.bajars → created an issue.