- 🇭🇺Hungary segi
I re-rolled my patch if somebody use it. I have check the MR and it looks promising and it covers my little "fix" as well.
- 🇺🇸United States bradjones1 Digital Nomad Life
Thanks, although to be clear the MR is the code that is under review, the patch is outdated and is not the subject of the issue any longer.
- 🇲🇺Mauritius Arnaud Kali Roches-Brunes, Beau-Bassin
@bradjones1 I don't seem to be able to review/test that patch from #12. I cant apply the patch to 5.2.x either as the code seems to be outdated. I'm seeing the merge request and actually needing it on one of my projects, I'd guess it's about to be merged and released?
- 🇺🇸United States bradjones1 Digital Nomad Life
I don't seem to be able to review/test that patch from #12. I cant apply the patch to 5.2.x either as the code seems to be outdated.
Yes, I'd consider that patch to be outdated so I can't help you here and not sure why you're trying to apply it.
I'm seeing the merge request and actually needing it on one of my projects, I'd guess it's about to be merged and released?
It will get released when it gets to RTBC, so I welcome the effort to review it. Feel free to apply the diff from the MR to your project and tell me how it goes. The fact it's an MR doesn't mean anything regarding its timeline to release. Patches are going away imminently on drupal.org, anyway.
- 🇲🇺Mauritius Arnaud Kali Roches-Brunes, Beau-Bassin
Thanks for your comment @bradjones1 - Even if I kinda know after I've been around on d.o for such a long time, I'm just never sure about the way to proceed. I'm re-rolling the patch against 5.2.x as I need an online link to be able to test on my platform (which already has an online API from which I need to test that code).
Thanks! I'll keep you informed of my findings.