Reduce logging severity/don't log expired tokens/401s

Created on 23 September 2019, about 5 years ago
Updated 6 February 2023, almost 2 years ago

It's a common pattern for clients to attempt a request with an access token, and if it responds with a 401 HTTP status code, refresh and try again. Currently this module logs these as errors, which is probably log spam in the sense that it's not a very actionable error for administrators on the server-side.

Generating proper response codes is handled in #2840205: Error messages/codes should be more helpful & match spec. β†’ - this issue is for the logging component.

πŸ“Œ Task
Status

Needs review

Version

5.2

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States bradjones1 Digital Nomad Life

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡­πŸ‡ΊHungary segi

    I re-rolled my patch if somebody use it. I have check the MR and it looks promising and it covers my little "fix" as well.

  • πŸ‡ΊπŸ‡ΈUnited States bradjones1 Digital Nomad Life

    Thanks, although to be clear the MR is the code that is under review, the patch is outdated and is not the subject of the issue any longer.

  • πŸ‡²πŸ‡ΊMauritius Arnaud Kali Roches-Brunes, Beau-Bassin

    @bradjones1 I don't seem to be able to review/test that patch from #12. I cant apply the patch to 5.2.x either as the code seems to be outdated. I'm seeing the merge request and actually needing it on one of my projects, I'd guess it's about to be merged and released?

  • πŸ‡ΊπŸ‡ΈUnited States bradjones1 Digital Nomad Life

    I don't seem to be able to review/test that patch from #12. I cant apply the patch to 5.2.x either as the code seems to be outdated.

    Yes, I'd consider that patch to be outdated so I can't help you here and not sure why you're trying to apply it.

    I'm seeing the merge request and actually needing it on one of my projects, I'd guess it's about to be merged and released?

    It will get released when it gets to RTBC, so I welcome the effort to review it. Feel free to apply the diff from the MR to your project and tell me how it goes. The fact it's an MR doesn't mean anything regarding its timeline to release. Patches are going away imminently on drupal.org, anyway.

  • πŸ‡²πŸ‡ΊMauritius Arnaud Kali Roches-Brunes, Beau-Bassin

    Thanks for your comment @bradjones1 - Even if I kinda know after I've been around on d.o for such a long time, I'm just never sure about the way to proceed. I'm re-rolling the patch against 5.2.x as I need an online link to be able to test on my platform (which already has an online API from which I need to test that code).
    Thanks! I'll keep you informed of my findings.

  • πŸ‡²πŸ‡ΊMauritius Arnaud Kali Roches-Brunes, Beau-Bassin
  • πŸ‡±πŸ‡»Latvia artis.bajars

    artis.bajars β†’ made their first commit to this issue’s fork.

  • Pipeline finished with Failed
    4 months ago
    Total: 31s
    #275494
  • Pipeline finished with Failed
    4 months ago
    Total: 31s
    #275495
  • πŸ‡¨πŸ‡¦Canada TrevorBradley

    Adding a request to also look at this issue for the new 6.x branch.

    Would love to have a little more control over the >3,000 daily simple_oauth errors in the logs on our high volume site.

  • First commit to issue fork.
  • πŸ‡§πŸ‡ͺBelgium dieterholvoet Brussels

    I created a MR based on 6.0.x.

Production build 0.71.5 2024