Undefined array key warning in UrlHelper::parse()

Vivek Panicker → made their first commit to this issue’s fork.

Tests are failing because of media_library test https://git.drupalcode.org/issue/drupal-3442833/-/jobs/1413833#L79.
Not sure how to resolve it.

Current development branch is 11.x

Can't just add this though it will have to have backward compatibility coverage for the typehint being added. With a deprecation.

The type hint would not fix the issue.
You can see in the steps to reproduce that I am passing a string.

Binoli Lalani → made their first commit to this issue’s fork.

Hello,

I can reproduce the error in drupal 11.x and raised MR against 11.x branch. Please review.

Thank you!

Since this is a component class believe we will need test coverage

Hello @smustgrave,

Thank you for reviewing the code. I have added test coverage for the warning. Please review.

Thank you!

Not 100% the use case but the test does show the failure

1) Drupal\Tests\Component\Utility\UrlHelperTest::testParse with data set #5 ('#/://#', array(null, array(), '/://#'))
Undefined array key 1
/builds/issue/drupal-3442833/core/lib/Drupal/Component/Utility/UrlHelper.php:213
/builds/issue/drupal-3442833/core/tests/Drupal/Tests/Component/Utility/UrlHelperTest.php:272
/builds/issue/drupal-3442833/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
/builds/issue/drupal-3442833/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/builds/issue/drupal-3442833/vendor/phpunit/phpunit/src/Framework/TestSuite.php:685
/builds/issue/drupal-3442833/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/builds/issue/drupal-3442833/vendor/phpunit/phpunit/src/TextUI/Command.php:146
/builds/issue/drupal-3442833/vendor/phpunit/phpunit/src/TextUI/Command.php:99
ERRORS!
Tests: 161, Assertions: 165, Errors: 1.

And checking if empty doesn't seem to hurt. LGTM.

Left a suggestion on the MR to preserve the logic of which bit of logic processes external urls and which processes internal.

pradhumanjain2311 → made their first commit to this issue’s fork.

prudloff → changed the visibility of the branch 3442833-undefined-array-key to hidden.

I believe @alexpott's comment have been addressed.

Feedback appears to be addressed

Backported down to 10.4.x as an eligible bug fix.

Committed and pushed 9307769b8b1 to 11.x and 56da864154b to 11.1.x and 4bf739cf9e9 to 10.5.x and ea023626eaa to 10.4.x. Thanks!

longwave → closed merge request !7721

Automatically closed - issue fixed for 2 weeks with no activity.