Removed deprecated code in Render system

Binoli Lalani → made their first commit to this issue’s fork.

Searching for deprecated and 11.0

Appears to be another instances in HtmlResponseAttachmentsProcessor

Left some comments.

pradhumanjain2311 → made their first commit to this issue’s fork.

Hello,

Thank you for reviewing the code. I have updated the code as per the comment on MR. Please review.

Thank you!

The UrlGenerator tests should not be removed here, they are being done in 📌 Remove deprecations for UrlGenerator methods Needs review

Hello,

I have reverted UrlGenerator code. Please review.

Thank you!

Believe the deprecation tests are still there.

Fixed up the MR, all green.

Looks like all feedback has been addressed here, The removal looks good to me as well.

Needs rebase, added some comments about property promotion, and this can be removed too:

  use DeprecatedServicePropertyTrait;

  /**
   * Defines deprecated injected properties.
   *
   * @var array
   */
  protected array $deprecatedProperties = ['cacheTagInvalidator' => 'cache_tags.invalidator'];

Addressed feedback.

Ugh, I missed those, thanks. Feedback addressed. Back to rtbc

Couple more questions on the MR.

Address feedback.

Still one remaining I think.

Hope now it ready

That looks great now.

There is still one error around the renderer config.

Applied suggestion - it means there's no test for debug(

That’s my bad. Got too eager with promotion

Committed d60d2ce and pushed to 11.x. Thanks!

please close MR

longwave → closed merge request !7534

Automatically closed - issue fixed for 2 weeks with no activity.