Remove deprecations for UrlGenerator methods

saurabh rawat → made their first commit to this issue’s fork.

removed deprecation test

Removal appears to be correct.

Thought about expanding this to include all deprecation in Routing but that would be a lot. This is well scoped.

One question on the MR.

@thhomas could you answer the question though. Was suggested to open a follow up and maybe throw an exception.

Given we already did the deprecation I think we can just add the string type here, I don't see the need to defer that to a different issue.

Yeah #12 makes sense to me, wish I'd thought of that in the first place.

Fixed the above, also taken the liberty here to add array types where necessary and also implement all types that are present on the Symfony interfaces.

Seems to have a Unit test failures.

Fixed, we extend ::generate() so it can take boolean as well as int in the third argument, fixed the signature here so this is allowed.

Removal seems good now.

Yes this looks great, glad we added the type hints here.

Committed/pushed to 11.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.