Only allow route names, deprecate support for route objects in UrlGenerator methods

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

📌 Deprecate UrlGenerator::supports() and UrlGenerator::getRouteDebugMessage() Fixed is RTBC except for a re-roll, might be worth waiting on that just to avoid any potential conflicts.

I think this patch is in good shape except we need to update the deprecation messages to drupal:10.1.0 for removal in drupal:11.0.0.

re-roll for 10.1 and there's only context conflict with 📌 Deprecate UrlGenerator::supports() and UrlGenerator::getRouteDebugMessage() Fixed so better to commit it

+++ b/core/modules/comment/src/Plugin/Field/FieldFormatter/CommentDefaultFormatter.php
@@ -178,7 +178,7 @@ public function viewElements(FieldItemListInterface $items, $langcode) {
-            $build['pager']['#route_name'] = $this->routeMatch->getRouteObject();
+            $build['pager']['#route_name'] = $this->routeMatch->getRouteName();

+++ b/core/modules/config_translation/src/Form/ConfigTranslationFormBase.php
@@ -219,7 +219,7 @@ public function submitForm(array &$form, FormStateInterface $form_state) {
-      $this->mapper->getOverviewRoute(),
+      $this->mapper->getOverviewRouteName(),

this 2 places anyway needs fix

It needs follow-up to remove deprecated methods in D11 and new method UrlGenerator::getRouteStringIdentifier() added in related issue 📌 Deprecate UrlGenerator::supports() and UrlGenerator::getRouteDebugMessage() Fixed

Filed follow-up 📌 [11.x] Disallow passing route objects to UrlGenerator methods Postponed and waiting for 📌 Deprecate UrlGenerator::supports() and UrlGenerator::getRouteDebugMessage() Fixed

blocker commited, here's re-roll and polishing of test and place to throw deprecation

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Umm, issue with the bot

Somehow re-testing aborted, queued PHP 8.2 meantime but curious if there's some performance regression happened

tests are passed, I see no difference in time - the same 1h for run

Deprecation message is up to date,
Change record is simple and clear.
Has test coverage for deprecation.
Code looks good to me.

Committed to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.