- Issue created by @Binoli Lalani
- Merge request !1Issue #3353181: Fix the issues reported by phpcs โ (Open) created by Binoli Lalani
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 8:52am 10 April 2023 - Status changed to Needs work
4 months ago 12:18pm 7 March 2024 - ๐ฎ๐ณIndia Ashutosh Ahirwal India
Hi Provided MR resolved issue but still there are some issue found.
Moving to need work to get notice.
Used command:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/querybuilderFILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/querybuilder/querybuilder.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/querybuilder/src/Form/OptimiseDatabaseForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
35 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------Time: 94ms; Memory: 10MB
- ๐ฎ๐ณIndia Mohd Sahzad
Mohd Sahzad โ made their first commit to this issueโs fork.
- Status changed to Needs review
4 months ago 5:28am 8 March 2024