Contrib.social

Fix the issues reported by phpcs

Open on Drupal.org →
Created on 10 April 2023, over 1 year ago
Updated 30 July 2024, 4 months ago

Problem/Motivation

FILE: /querybuilder/src/Form/OptimiseDatabaseForm.php
--------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------
  6 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
  9 | ERROR | [x] Missing class doc comment
 31 | ERROR | [x] Short array syntax must be used to define arrays
 51 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /querybuilder/querybuilder.links.menu.yml
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 18 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

FILE: /querybuilder/querybuilder.permissions.yml
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
 36 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

FILE: /querybuilder/README.txt
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
 42 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: /querybuilder/config/install/querybuilder.settings.yml
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: /querybuilder/querybuilder.routing.yml
-----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
 21 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml querybuilder

Proposed resolution

Fix the errors.

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

🇮🇳India Binoli Lalani Gujarat

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Binoli Lalani
  • Merge request !1Issue #3353181: Fix the issues reported by phpcs → (Open) created by Binoli Lalani
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India Binoli Lalani Gujarat

    Hello,

    Please review MR.

    Thank you!

  • Status changed to Needs work 9 months ago
  • Comment 9 months ago →
    🇮🇳India Ashutosh Ahirwal India

    Hi Provided MR resolved issue but still there are some issue found.
    Moving to need work to get notice.
    Used command:-
    ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/querybuilder

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/querybuilder/querybuilder.info.yml
    -----------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------
    1 | WARNING | "core_version_requirement" property is missing in the info.yml file
    -----------------------------------------------------------------------------------------------------------

    FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/querybuilder/src/Form/OptimiseDatabaseForm.php
    -----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------------------------------------
    35 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
    -----------------------------------------------------------------------------------------------------------------------------------------

    Time: 94ms; Memory: 10MB

  • Comment 9 months ago →
    🇮🇳India mohd sahzad

    Mohd Sahzad → made their first commit to this issue’s fork.

  • Status changed to Needs review 9 months ago
  • Comment 9 months ago →
    🇮🇳India mohd sahzad
  • Status changed to RTBC 4 months ago
  • Comment 4 months ago →
    🇵🇭Philippines cleavinjosh

    Hi @Mohd Sahzad,

    I applied MR!1, it was applied smoothly and fixed the phpcs issues.

    ➜  querybuilder git:(8.x-1.x) curl https://git.drupalcode.org/project/querybuilder/-/merge_requests/1.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3912    0  3912    0     0   8938      0 --:--:-- --:--:-- --:--:--  8951
patching file README.txt
patching file config/install/querybuilder.settings.yml
patching file querybuilder.info.yml
patching file querybuilder.links.menu.yml
patching file querybuilder.permissions.yml
patching file querybuilder.routing.yml
patching file src/Form/OptimiseDatabaseForm.php
➜  querybuilder git:(8.x-1.x) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml querybuilder
➜  contrib

    Thank you.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024