"Unsaved changes" message incorrectly appears on layout builder

@AndyThornton could you please share your solution ("own version of that subscriber")?

Patch from #20 doesn't work with 10.3.0 because of "Add static caching to LayoutTempstoreRepository"

https://www.drupal.org/project/drupal/issues/3445909 🐛 Add static caching to LayoutTempstoreRepository Fixed

Update patch #20 to be compatible with Drupal 10.3

Carlos Romero → made their first commit to this issue’s fork.

Applied changes from patch #37 to the corresponding branches and created mr

smustgrave → changed the visibility of the branch 11.x to hidden.

smustgrave → changed the visibility of the branch 3207875-unsaved-changes-message to hidden.

MR appears to have test failures.

binoli lalani → made their first commit to this issue’s fork.

Hello,

I merged latest code changes from base branch into fork's branch and rerun the pipeline. Testcases are passed. Please review.

Thank You!

Left comments on MR.

Hello,

Thank you for reviewing the code. I pushed the code for comment on MR. Please review.

Thank you!

Verified the issue on 11.x-dev.

Steps to be followed to verify the issue.

Scenario 1:

1. Navigate to any content type by admin > structure > content types.
2. Edit content type by clicking manage fields.
3. Navigate to manage display tab.
4.navigate to layout option section and enable "use layout builder"
5.Save the changes and click "manage layout" button.
6.Refresh the page and you will see "unsaved changes" message.

Scenario 2:
1. Navigate to any content type by admin > structure > content types.
2. Edit content type by clicking manage fields.
3. Navigate to manage display tab.
4.navigate to layout option section and enable "use layout builder" and "Allow each content item to have its layout customized."
5.Create a node and Click the "Layout" tab.
6.Refresh the page and you will see "unsaved changes" message.

Issue was there in both scenarios before applying the MR!9333.

After The MR!9333 issue resolved for both scenarios. I suggest move this issue to RTBC

Attached screenshots for reference.

Feedback appears to be addressed

Saving credit.

I made two comment changes using the suggestions feature. Then phpstan was failing so I regenerated the baseline as well as properly wrapping one of the comments. There were no code changes.

Therefor I will leave this at RTBC.

Kudos to whoever decided to put the sections inside a top-level key named 'section_storage' so we don't have any BC update path issues here.

It looks like #27.1 has not been answered yet, back to NR for that

Patch from #37 worked for me. I was getting following error.

Fatal error: Declaration of Drupal\layout_builder\LayoutTempstoreRepository::set(Drupal\layout_builder\SectionStorageInterface $section_storage) must be compatible with Drupal\layout_builder\LayoutTempstoreRepositoryInterface::set(Drupal\layout_builder\SectionStorageInterface $section_storage, $has_unsaved_changes = true) in C:\laragon\www\commerce\web\core\modules\layout_builder\src\LayoutTempstoreRepository.php on line 80

Hi, I’ve tried patch → #37 🐛 "Unsaved changes" message incorrectly appears on layout builder Needs work , and it worked for me. Please find the attached screenshots as evidence.

Thank you!

Please don't put an issue back to RTBC without addressing the question/reason it was set the needs review

We need to answer the question in 27.1

Thanks

I would like to add one more thing regarding patch in #37 is that i had to apply it manually. I am using commerce kickstart V3. It has latest version of drupal 10.

On looking closely, I noticed that some part of the patch was already applied. I guess that is why it was not applying automatically.

Thought it may help.

I do not know what happened, I tried to clear all caches and now I am seeing the same error again suddenly.

Fatal error: Declaration of Drupal\layout_builder\LayoutTempstoreRepository::set(Drupal\layout_builder\SectionStorageInterface $section_storage) must be compatible with Drupal\layout_builder\LayoutTempstoreRepositoryInterface::set(Drupal\layout_builder\SectionStorageInterface $section_storage, $has_unsaved_changes = true) in C:\laragon\www\commerce\web\core\modules\layout_builder\src\LayoutTempstoreRepository.php on line 80

Isn't there any workaround?

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Hi, I've tried the patch from #37 🐛 "Unsaved changes" message incorrectly appears on layout builder Needs work , and it worked for me most of the time, but there's one case where the issue still occurs.

When I create a new page and immediately go to the Layout Builder, I see the message "You have unsaved changes" on the blank page. If I save the page, the message disappears. Any subsequent saves don't trigger this message — it only happens on a fresh, newly created page.

Patch 3207875--20.patch that worked before now does not apply for Drupal 10.4.5
I fixed it in this patch.

#63, #64 works good.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The patch changes from #64 need to be incorperated in the MR(s) listed as part of this issue.

As suggested in comment #67, I’ve pushed the changes from the patch in comment #64 to the 10.3.x-3207875 branch.
Please let me know if I missed anything or if there’s anything else that needs to be done.

carlos romero → closed merge request !12212

carlos romero → changed the visibility of the branch 10.3.x-3207875 to hidden.

carlos romero → closed merge request !12213

carlos romero → reopened merge request !12213

carlos romero → reopened merge request !12212

The latest changes to the 10.3.x-3207875 branch have caused errors in my production projects. I've reinstated the code. I have applied this patch to over 50 portals. Please be careful with the code you modify.

Regards.

It would be good to get the 11.x MR up to date with these changes too, fixes should go there first :). Thanks!

I have updated the patch for the 11.x branch to include the recent changes and fixes. Please review and let me know if there’s anything that needs adjustment.

I followed the Scenario 1 steps to reproduce the issue and #81 is working fine.

Attached before and after screenshots.