Add static caching to LayoutTempstoreRepository

Attached is a patch that adds static caching. This reduced the number of queries in a layout builder edit page from 912 to 227.

Before:

After:

We can't simply update the static cache when it is updated, so lets unset it. Sorry about that.

Can we turn to an MR first? (let reporter do it).

Also should we add test coverage now or should this be framework first

Added a MR. Not sure what the best approach would be to add test coverage. This shouldn't really change anything, except maybe the number of queries to the database. Also would love to get feedback from the framework managers if this is something they would consider adding.

This caused quite some issues. It probably makes more sense to add the caching to LayoutTempstoreRepository. This solves the issue I experienced with a lot less impact. Updated the MR and IS.

Tests are all green with the latest changes in the MR. Impact on the amount of queries is the same. From about a 1000 queries to 250 queries for a page with a bunch of layout builder components. 🎉

Do wonder if this will need test coverage? To my knowledge we don't have performance tests on layout builder, which would be very out of scope here.

Going to mark but maybe a follow up for layout builder performance should be opened? That's a question for the committer. But the change here looks good.

I think the implementation here is fine and I think testing this beyond that is has not broken anything is fine. And the manual testing provided by @seanB is good. Just a small nit on the MR to address. Also the fact that so many queries are necessary on the page is a bug.

Feedback appears to be addressed.

One question on the MR.

Moving back to RTBC because thread has an answer.

Was debating whether we should use a static cache service here and inject it, or not to bother; given we can always swap to using a service later if we need to let's just get this in as a nice performance improvement.

Backported to 10.3.x as an eligible bug fix.

Committed and pushed 27c9bcca6f to 11.x and 076279a6c4 to 11.0.x and 282aed1317 to 10.4.x and d9111a4782 to 10.3.x. Thanks!

longwave → closed merge request !8015

Automatically closed - issue fixed for 2 weeks with no activity.