As @jrockowitz mentioned there is no feature implementation for now, I have skipped MR!356 from testing (however MR failed test cases). Tested patch #4. followed all the steps which are given in "Steps to reproduce"
After overriding blockSubmit function the behaviour is same as before while uploading file and submitting. If and only we want blockSubmit function to be overridden then we can use patch #4. else we can use the module AS-IS.
Attached screenshot for reference.
In that case, better we can consider #5 which is mainly focused on this ticket.
Tested patch #5 and patch #6 on my local drupal 10.1. Firstly Please note that both patches are same, only the difference in patch #6 is removal of 171 line i.e " $export_options += $submission_exporter->getDefaultExportOptions();". Done testing with this line of code and without also. Both cases the result is same. "--excluded-colums" is working as expected after applying both patches. attaching Screenshot for reference. Let maintainer decide which is the best patch to consider. Both patches resolve the issue which is stated here.
We can move this to RTBC+1
Reviewed MR!10 on drupal 10.1 on my local. this MR will resolve the issue reported here. Thanks @gisle for highlighting the MR which I have not considered while reviewing. compared both MR!10 and patch #6. patch #6 carries the same changes which are there in MR!10.
Tested Patch #6 on drupal 10.1.
As stated in description error is reproducible using the steps below
1. Go to this path : admin/config/content/node-title-validation
2. Configure the module by filling up the required inputs
3. Save the module configurations
4. You will get an error
Attached Before patch screen recording and screenshots for reference.
After applying patch #6 error resolved successfully. I am able to configure the module and messenger is coming up when clicked on save button. MessengerInterface is implemented successfully.
We can move this to RTBC+1.
All good on 10.0. Its showing as token is upto date. I have not faced any update errors which is stated in #3. Attached ss for reference.
Thanks.
Before adding #3 patch I have observed that css/js aggregation settings are there in performance form and as mentioned in the summary since drupal 10.1 there is a development form for development settings. Twig debugging , cache settings are there in development form. I have added screenshots for both the observation i.e 1. Development form Before Patch and 2.Performance form Before Patch.
navigate to Admin>configuaration>development>Performance to view performance form
navigate to Admin>configuaration>development>development settings to view development settings form
As per the scope of this issue CSS/JS aggregation settings needs to be moved to development settings form. Installed drupal 11.x on my local and Applied #3 patch on that. As per the scope CSS/JS aggregation settings are moved to development settings form from performance form. patch is working as expected. Attached screenshots of development settings form and performance form for reference. i.e 1. Development form after Patch 2.Performance form after Patch.
Hence suggest to moving this issue to RTBC +
I am reviewing this #3 patch
I have done these steps to replicate the issue.
Installed webform 6.2.0-beta6 on my local
Created single check box webform
Enabled webform share
In share settings I have unchecked "Display title on shared form"
I have found that before applying the #4 patch title was showing on shared webform.
I have applied #4 patch and the issue which I am facing got resolved. I have verified the shared webforms in test page of shared webforms. attaching a video and screenshots before and after applying the patch.
Hence #4 resolves the issue which is mentioned here. Moving to RTBC.
Hi @guardiola86, as mentioned by @Indrapatil #2 patch applied successfully and I am unable to reproduce the error which is reported. Things are working as expected. We can move this to RTBC.