Header is always shown in Claro even when regions in it are empty

This patch fixes this behaviour for me

prashant.c → made their first commit to this issue’s fork.

• @f0ns Assigning no regions, do you mean from the themes info file or removing the content assigned to the regions?
• Because I replicated this by removing/disabling the blocks and content to all the regions and not by removing regions.
• The Submitted path does solve the issue, creating MR using the same.

However, I think appropriate conditions could also be added for the remaining part as well for the {{ page.pre_content }}{{ page.highlighted }}<code> and {{ page.content }}:

<div class="layout-container">
      {{ page.pre_content }}
      <div class="page-content clearfix">
        {{ page.highlighted }}
        {% if page.help %}
          <div class="help">
            {{ page.help }}
          </div>
        {% endif %}
        {{ page.content }}
      </div>
  </div>

Fixes verified on 11.x-dev.

I was able to reproduce the issue on my local environment. After applying fix from the MR!9340 issue resolved.

Steps followed for reviewing:
1. Installed 11.x-dev on local.
2. Navigate to admin > structure > Block layout
3. Make sure you are on claro theme tab for block placement.
4. Disable all the blocks which are placed in Header and Breadcrumb region.
5. Navigate to home page and check for the header.

After the MR!9340 header is not shown when the region is empty.

Attached screenshots for reference.

Issue mentioned is resolved after the MR. I suggest move this issue to RTBC

Tested on Drupal 11, and is working as expected with this patch.

---
Thanks to The Confident for sponsoring my time to work on this.

Thank you for testing, looks good to go.

Concerning comment #6, personally I don’t see the need to add extra control statements to other regions as these elements have no containers that have any css markup in core.

nod_ → closed merge request !9430

Committed and pushed 5360e3bdb08 to 11.x and 946c580a097 to 11.0.x and bca9ac9378f to 10.4.x and 0a4577802ac to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.