OEmbed fails to save if thumbnail fails to download

Updating patch to fix issue with NULL $thumbnail_url :

Deprecated function: file_get_contents(): Passing null to parameter #1 ($filename) of type string is deprecated in Drupal\media\OEmbed\Resource::rich() (line 312 of /var/www/html/web/core/modules/media/src/OEmbed/Resource.php)

Improved patch a bit - moved logic to resource fetcher which will do thumbnail dimensions processing at the oembed API call to source and data parsing. This will allow us to use resources much more efficient, as this data will be cached.

In case we keep following code in Resource class it will multiple times do same job - download thumbnails and parse it's width/height.

Also I found issue in prev patch - when there are thumbnail width, height and url available - it will set $thumbnail_url to NULL which will broke everything and no thumbnails will be generated at all.

As a bug will need a test case showing the issue. Also may want to write it for 11.x as it will have to land there first to be backported.

andreastkdf → changed the visibility of the branch 3331771-oembed-fails-to to hidden.

added a new MR for 10.3.x but agree about this needing to be rerolled for 11.x

The MR9471 basically contain both #6 🐛 OEmbed fails to save if thumbnail fails to download Needs work and #7 🐛 OEmbed fails to save if thumbnail fails to download Needs work . A note about #7 🐛 OEmbed fails to save if thumbnail fails to download Needs work : RessourceFetcher calls createResource which calls Resource:rich too, so the fix on #6 🐛 OEmbed fails to save if thumbnail fails to download Needs work is needed to fix the ValueError: Path cannot be empty in file_get_contents()error.

andreastkdf → closed merge request !9471

andreastkdf → changed the visibility of the branch 333177 to active.

added a new MR to re-roll for 10.3.x (this still needs to be rerolled for 11.x)