Added new filter definition to re-use "user_name" filter handler from core user module. This adds autocomplete to filter widget, so user can easily filter threads by it's members.
Also there is an alternative way to achieve similar behavior - apply core patch from https://www.drupal.org/project/drupal/issues/2429699 📌 Add Views EntityReference filter to be available for all entity reference fields Closed: duplicate and add next to your custom code:
/**
* Implements hook_views_data_alter().
*/
function your_module_views_data_alter(array &$data) {
$data['private_message_thread__members']['members_target_id']['filter']['id'] = 'entity_reference';
}
Clear your cache and this will make members field looks like eneity reference with different settings.
If you experience duplicates - this is completely fine and normal behavior of SQL query. To fix so - enable aggregation and select "Group results together" in aggregation type settings.
id.conky → changed the visibility of the branch 3322625-add-ability-to to active.
id.conky → changed the visibility of the branch 3322625-add-ability-to to hidden.
id.conky → made their first commit to this issue’s fork.
id.conky → made their first commit to this issue’s fork.
+
Pushed my work to git, merge request opened, please check.
For anyone who want to test this here is a patch: https://git.drupalcode.org/project/node_read_time/-/commit/db5f2d18797dd...
id.conky → created an issue.
Improved patch a bit - moved logic to resource fetcher which will do thumbnail dimensions processing at the oembed API call to source and data parsing. This will allow us to use resources much more efficient, as this data will be cached.
In case we keep following code in Resource class it will multiple times do same job - download thumbnails and parse it's width/height.
Also I found issue in prev patch - when there are thumbnail width, height and url available - it will set $thumbnail_url to NULL which will broke everything and no thumbnails will be generated at all.
Definitely war, not conflict!
@ahebrank, please check updated code. Opened MR: https://git.drupalcode.org/project/media_library_edit/-/merge_requests/13
For anyone else, who want to test this out - please install dev version of the module and apply this patch.
Cool, thanks! This issue can be closed now.
id.conky → created an issue.
Added Drupal 10 compatibility fixes, improved code styling and documentation. Refactored code a bit.
MR: https://git.drupalcode.org/project/private_message/-/merge_requests/45
Added issue tag for Lutsk Global Contribution Weekend 2023.
id.conky → made their first commit to this issue’s fork.