🇦🇹Austria @a.milkovsky

@Mikechr thank you for the update!
I think this issue can be closed.

a.milkovsky → created an issue.

I agree. Would you be interested to collaborate on such a contrib module?

a.milkovsky → created an issue.

a.milkovsky → created an issue.

a.milkovsky → created an issue.

It is nice to have this feature back!
Note: I would give a credit to Szabocs Páll for the initiative and the initial development.

jjchinquist → credited a.milkovsky → .

@dima.iluschenko as a temporary solution, we have created a custom module and added the code from the PR there.
The solution works for us.

Added an additional check `isset($element['#default_value'])`

The PR looks good.

a.milkovsky → created an issue.

Added on additional case to check for EntityInterface.

Somehow the loaded entity gets lost after clicking on the "Add more" button. Trying to find a fix.

@sinn see my patch #5.
The `processEntityAutocompleteDefaultValue` method already supports the entityTypeManager entity load by any target entity type (not only "node" as in your example. In addition the method processes a non-integer value, in the entity_autocomplete format.

Looks good and works nice with CKEditor 5.

As I can see in the Migrating from TCF 2.0 to TCF 2.2 article, this framework is configurable in the Cookiebot configuration. Changing this value from IAB to TCF2.2 may lead to an unexpected behavior of existing websites.

Instead we should add a possibility to select the data framework in Drupal settings.

Thnak you for the clarification, looks good to me!

We used Cookiebot logo previously. But we decided to remove it because of the rights to the logo.

Here is a patch (unfortunately without tests, as it would require the unique_queue module).
Check if you like the idea.

a.milkovsky → created an issue.

Hi @silversk8r, @Alina Basarabeanu . I have recently marked this module as obsolete as it does not support CKEditor 5.
CKEditor 5 already provides quite some features to work with tables.
See module the description page for more details.

@jwilson3, thank you. I have updated the module description.

@Wim Leers, thank you. I will mention this issue in the CKEditor Table Resize → module and will mark it as obsolete as well.

Thank you @jwilson3 for reporting. This module does nothing special but adding a CKE 4 library. If you know a CKEditor 5 plugin, that support the mentioned features, we could create a Drupal
integration for it.

@adriancid, thank you for pointing at this.
It is indeed possible to do everythink from the box in Drupal 10.

I will mark this module a deprecated.

a.milkovsky → created an issue.

We only use the cookies.set and cookies.get functions. We could use vanilla JS for this.

#4 solves the issue.

It is a war. +1 for RTBC

I would like to use this module with the CKEditor 4 which is part of Drupal core now.

The core module is actually CKeditor 5, the version 4 was moved to a contrib module.

Unfortunately we can not easily swap the CKEditor versions, as this module (CKEditor Table Selection) is using the https://ckeditor.com/cke4/addon/tableselection library which is compatible with CKeditor4 only.
@mirtina2k, do you know an alternative library for CKeditor 5?

This path fixes the typo in query.

I'm a bit confused by this now... So there's both a JS error and the error with the event class?

@jsacksick #6, the event class change did not help me. The error came from js. I am still not happy with the solution, as it works unstable. That's why we decided to deactivate this payment type for now. I plan to get back to it again and debug a bit more.

@TomTech your patch #8 is empty.

We have experienced the same issue. In addition we can see a js error "Paypal Response "Expected an Order ID to be passed".

As @slashsharp noted, the error happens in the messages.add(data.responseJSON.message, options); line, where data is a string with order id and not an object.

This promise was added in #3303443: Enhance Exception Handling on Ajax calls → . I am not sure why data does not contain responseJSON in this case.

The next patch removed this promise and fixes the payment process.

The patch #6 looks good. As the related issue #2880160 haven't got any progress since 4 years, it makes sense to commit the current patch.

I guess this issue can be closed as outdated, as there was no activity for 1 year. Also the patched lines do not exist anymore.

@AndyThornton could you please share your solution ("own version of that subscriber")?

First of all, the patch #27 works great for me, amazing work!

I agree with others, that UI can be improved. Probably a follow-up issue can be opened to create a contextual drop-down menu for action-links "Configure section", "Change layout".

I created a merge request from @dsnopek’s patch in #27, feel free to pick it up.

The MR targets the 9.5.x branch for now, as the patch does not apply to 10.1.x-dev.

a.milkovsky → made their first commit to this issue’s fork.