UTC +2
Account created on 12 January 2012, over 13 years ago
#

Merge Requests

Recent comments

🇦🇹Austria a.milkovsky UTC +2

Regression: empty riddles are created.

🇦🇹Austria a.milkovsky UTC +2

Service container cache is rebuild if you clear the `container` cache. drush cc container.
This cache clear command is a part of drush cr.

If you want to clear the container cache separately from other caches, you mat want to use the deployment_identifier.

🇦🇹Austria a.milkovsky UTC +2

Fixed error on libeblog post deletion:

Error: Call to a member function id() on null in Drupal\liveblog_pusher\Plugin\LiveblogNotificationChannel\PusherNotificationChannel->triggerLiveblogPostEvent() (line 172 of modules/contrib/liveblog/modules/liveblog_pusher/src/Plugin/LiveblogNotificationChannel/PusherNotificationChannel.php).

🇦🇹Austria a.milkovsky UTC +2

Thank you @unmon,

do you see any error in browser console?

Currently this module is not used by me in any ongoing project. But I can have a look in my free time.

Any patch is welcome.

🇦🇹Austria a.milkovsky UTC +2

This patch is not necessary in the stable release anymore. Let's close?

🇦🇹Austria a.milkovsky UTC +2

In this case, the case is closed.
Thank you for checking this.

🇦🇹Austria a.milkovsky UTC +2

The changes are not relevant. Needs work for the latest branch.

🇦🇹Austria a.milkovsky UTC +2

Hi I am a new module co-maintainer of Riddle Market place.

As mentioned previously, Riddle.com has released a new API v3.
For the integration with the new API version a new 4.x branch was started in this project.

It looks like both the Riddle API v2 and API v1 are obsolete now, thus I so not plan to maintain the 8.x-3.x branch actively.
Please consider using the new 4.x branch for both the latest API v3 integration and Drupal 10 support.

Existing patches can still be applied for the v2 integration. Feel free to review the changes in #16.

🇦🇹Austria a.milkovsky UTC +2

As meanwhile Riddle API v3 was released, I am moving this issue to the new module version.

🇦🇹Austria a.milkovsky UTC +2

As meanwhile Riddle API v3 was released, I am moving this issue to the new module version.

🇦🇹Austria a.milkovsky UTC +2

As meanwhile Riddle API v3 was released, I am moving this issue to the new module version.

🇦🇹Austria a.milkovsky UTC +2

As meanwhile Riddle API v3 was released. I am moving this issue to the new module version.

🇦🇹Austria a.milkovsky UTC +2

Agenda: update php, Drupal
work in progress...

🇦🇹Austria a.milkovsky UTC +2

I installed the la_eu distribution locally. First impressions:

Setup:

  • Tthe setup process is not properly described. The readme needs some updates and clarifications.
  • It is not clear how to contribute and separate the la_eu code from our custom code. The project It is not a distribution, but basically a snapshot of the entire project. There is an open issue for this https://www.drupal.org/project/la_eu/issues/3414966 🌱 Define contribution process Active

Functionality:

  • looks fancy
  • There is not much custom code in modules. The theme is very customized though
  • available content types:
    • basic page - used for simple pages like Impressum, AGB.
    • Case - case studies/projects. Uses Paragraphs.
    • Component page - marketing pages with a lot of layout components. Uses Layout builder
    • Event
    • News
    • Partner - companies/agencies that are sponsors. Also they can be referenced in Case studies.

Migration thoughts:

  • the available content types do cover our needs. we currently have: Article, Page, Project, Veranstaltung, Organisation.
  • He have some legacy content types, that we should remove/merge: Blogeintrag, Link, Nachbericht, Ort, Panel, Presse, Slideshow, Sponsor, Webform
  • it should be easy to migrate all the data. All the marketing pages ("Component pages") I would create from scratch.

Concerns:

  • Inconsistent layout implementation: Why was they layout builder used for Component pages but not for Case pages? Paragraphs are used for Cases instead.
  • As mentioned above, we should find a way how to separate our custom code from la_eu.
🇦🇹Austria a.milkovsky UTC +2

What do you think about making a distribution?

🇦🇹Austria a.milkovsky UTC +2

This feature does not require any personal user information.

The data storage could only contain a simple array with Drupal user id, tour id and a tour step. Of course we should update the values if either user entity gets deleted or if tour step does not exist anymore.

If you do not find this functionality necessary in the main module, this can be done in a separate contrib module/submodule.

🇦🇹Austria a.milkovsky UTC +2

I have re-worked the patch:

  • Added Riddle projects support
  • Added Drupal 10 fixes
🇦🇹Austria a.milkovsky UTC +2

This is API v3 implementation based on https://www.drupal.org/project/riddle_marketplace/issues/3165244#comment... Use Riddle API v2 Needs work .

🇦🇹Austria a.milkovsky UTC +2

This patch solves next issues:

  1. The #12 works fine, but it checks only the first 50 riddles in a paged response. I extended the RiddleFeedService to fetch Riddles from all the pages.
  2. I addressed #14
🇦🇹Austria a.milkovsky UTC +2

@osopolar, We are using this patch for D10.

🇦🇹Austria a.milkovsky UTC +2

@osopolar, for now we are just planning to upgrade to the API v3.
I would like to release the implemented code to the community.
If this module is still relevant and maintainers agree to develop it further, I would release a patch here.
Otherwise I can create a new module/sandbox for this.

🇦🇹Austria a.milkovsky UTC +2

Update: Riddle API has a new version now - version 3. Only 1 token is needed now.
https://www.riddle.com/help/api/

Authentication

To access the API you need an API key. You can find or create new API keys on the API keys page in the Riddle creator. Once you have found or created an API key, you can use it to authenticate against the API.

Example Request:

URL: https://www.riddle.com/creator/api/v3/riddle/list
HTTP method: POST
Headers:
{
Authorization: "Bearer [your API key]"
}

🇦🇹Austria a.milkovsky UTC +2

@Mikechr thank you for the update!
I think this issue can be closed.

🇦🇹Austria a.milkovsky UTC +2

I agree. Would you be interested to collaborate on such a contrib module?

🇦🇹Austria a.milkovsky UTC +2

It is nice to have this feature back!
Note: I would give a credit to Szabocs Páll for the initiative and the initial development.

🇦🇹Austria a.milkovsky UTC +2

@dima.iluschenko as a temporary solution, we have created a custom module and added the code from the PR there.
The solution works for us.

🇦🇹Austria a.milkovsky UTC +2

Added an additional check `isset($element['#default_value'])`

🇦🇹Austria a.milkovsky UTC +2

Added on additional case to check for EntityInterface.

🇦🇹Austria a.milkovsky UTC +2

Somehow the loaded entity gets lost after clicking on the "Add more" button. Trying to find a fix.

🇦🇹Austria a.milkovsky UTC +2

@sinn see my patch #5.
The `processEntityAutocompleteDefaultValue` method already supports the entityTypeManager entity load by any target entity type (not only "node" as in your example. In addition the method processes a non-integer value, in the entity_autocomplete format.

🇦🇹Austria a.milkovsky UTC +2

Looks good and works nice with CKEditor 5.

🇦🇹Austria a.milkovsky UTC +2

As I can see in the Migrating from TCF 2.0 to TCF 2.2 article, this framework is configurable in the Cookiebot configuration. Changing this value from IAB to TCF2.2 may lead to an unexpected behavior of existing websites.

Instead we should add a possibility to select the data framework in Drupal settings.

🇦🇹Austria a.milkovsky UTC +2

We used Cookiebot logo previously. But we decided to remove it because of the rights to the logo.

🇦🇹Austria a.milkovsky UTC +2

Here is a patch (unfortunately without tests, as it would require the unique_queue module).
Check if you like the idea.

🇦🇹Austria a.milkovsky UTC +2

Hi @silversk8r, @Alina Basarabeanu . I have recently marked this module as obsolete as it does not support CKEditor 5.
CKEditor 5 already provides quite some features to work with tables.
See module the description page for more details.

🇦🇹Austria a.milkovsky UTC +2

@jwilson3, thank you. I have updated the module description.

@Wim Leers, thank you. I will mention this issue in the CKEditor Table Resize module and will mark it as obsolete as well.

🇦🇹Austria a.milkovsky UTC +2

Thank you @jwilson3 for reporting. This module does nothing special but adding a CKE 4 library. If you know a CKEditor 5 plugin, that support the mentioned features, we could create a Drupal
integration for it.

Production build 0.71.5 2024