- Issue created by @szabocs pรกll
- Status changed to RTBC
about 1 year ago 1:44pm 10 November 2023 - ๐ฆ๐นAustria a.milkovsky UTC +2
Looks good and works nice with CKEditor 5.
- Status changed to Needs work
about 1 year ago 2:00pm 13 November 2023 - ๐ฉ๐ชGermany volkerk
Tested this in drupal 10.1 standard profile and chrome:
* Create paragraph type text with text, formatted long field
* Add paragraphs field to article
* Add Split Paragraph Button to Basic HTML Input filterOn the create article (node/add/article) route I get js warning in console
ckeditor5-dll.js?v=39.0.1:5 toolbarview-item-unavailable {item: 'splitParagraph'} Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-toolbarview-item-unavailable
Pasting some text into the text paragraph, position cursor somewhere in the text and clicking the
split paragraph buttton in ck toolbar I getckeditor5-dll.js?v=39.0.1:5 Uncaught TypeError: this.splitNode is not a function or its return value is not iterable at split_paragraph.js?s42b6u:1:1261
Additionaly there is not build step config for rebuilding the js in build dir.
Add .nvmrc to specify node version used. - Status changed to Needs review
about 1 year ago 2:19pm 16 November 2023 - ๐ฎ๐นItaly szabocs pรกll
The issues above should be fixed now, also added an extra README for CKEditor5.
Also it no longer uses the Add-in-between, but the add more modal (like did the previous version). - Status changed to Needs work
12 months ago 8:39am 28 November 2023 - ๐ฉ๐ฐDenmark googletorp
The patch at github seems to have a lot of issues.
Trying to execute the button I get: Uncaught CKEditorError: t.closest(...).querySelector(...) is null
When using same editor outside paragraphs you also get a similar error on load about querySelector which crashes editors if you have multiple on the same page. In general seems like checks are missing for the different selectors. Example
document.querySelector('XX').something
will cause JavaScript TypeError if XX is not present on the page, so you always need to check the output of querySelector and act accordingly if what you expected is not on the page.
- ๐ฆ๐นAustria a.milkovsky UTC +2
@dima.iluschenko as a temporary solution, we have created a custom module and added the code from the PR there.
The solution works for us. - ๐ช๐ธSpain foreveryo
@a.milkovsky would mind to share the custom module? :-)
I tried mergint the PR on my side but the button does not appear :-(
Thanks!
- ๐ช๐ธSpain foreveryo
I managed to run it on my side but I had to make several changes mainly to the query selectors as for instance ".paragraphs-container" is not an standard css selector or at least is not existing in Gin theme. Which admin theme do you use?
- ๐บ๐ธUnited States greenskin
- ๐บ๐ธUnited States greenskin
I'm looking for a compatible solution with Layout Paragraphs โ . Pull request #80 does not seem to work with layout paragraphs.
- ๐ฉ๐ชGermany volkerk
@greenSkin Please add a follow-up for layout paragraphs support.
- Status changed to RTBC
7 months ago 11:16am 22 April 2024 - ๐ฉ๐ชGermany daniel.bosen
I reviewed it on GitHub, the issues I found with the PR have been fixed. lgtm.
- Status changed to Fixed
7 months ago 11:29am 22 April 2024 -
volkerk โ
authored 34517160 on 2.x
Issue #3400542 by Szabocs Pรกll, volkerk, a.milkovsky, googletorp, daniel...
-
volkerk โ
authored 34517160 on 2.x
- ๐ฆ๐นAustria a.milkovsky UTC +2
It is nice to have this feature back!
Note: I would give a credit to Szabocs Pรกll for the initiative and the initial development. - Status changed to Needs work
7 months ago 3:58am 23 April 2024 - ๐บ๐ธUnited States greenskin
Tested latest and still not working with Layout Paragraphs โ widget. The button shows but is disabled. I'm still seeing use of
.field--widget-paragraphs
. - Status changed to Fixed
7 months ago 7:16am 23 April 2024 - ๐ฉ๐ชGermany volkerk
@greenSkin Please do not reopen fixed issues. Support of layout_paragraphs is a feature request.
Please open a new issue. Automatically closed - issue fixed for 2 weeks with no activity.
- ๐บ๐ธUnited States capellic Austin, Texas
Great to see this functionality returned! Thanks!!