@saschaeggi: Could you please link to the issue in core?
volkerk → created an issue.
volkerk → made their first commit to this issue’s fork.
I tested this and moving the action buttons to static on configuration pages is a nice touch!
About the more actions dropdown I had a few thougths.
* Does it make sense to have the more actions functionality only kick in when there is more than a number of actions?
Also might be nice to have that configurable.
* I would suggest that we introduce alter functionality to be able to exclude certain actions from the dropdown button.
* I am not sure about having the meta sidebar toggle inside the more dropdown button. It is somehow central to the edit experience and also shows state?
Closing since remaining tasks have been fixed.
@greenSkin Please do not reopen fixed issues. Support of layout_paragraphs is a feature request.
Please open a new issue.
@greenSkin Please add a follow-up for layout paragraphs support.
We need a more in depth review other than posting two screenshots.
Tested with latest chrome and firefox esr, both default vertical toolbar and experimental new core nav.
Lgtm, nice.
Added check for libraries/dropzone/dist/min/dropzone.min.js in the test.
I am not sure for which library version / distribution libraries/dropzone/dropzone-min.js is applicable.
The module folder is concatenated with issue number in mr tests, therefore removed relevant part. See https://git.drupalcode.org/issue/dropzonejs-3424947/-/jobs/973387#L209
Ah, I see. Aligned the MR to use only the variant with dist and dot
@berdir: Added follow-up for dist file detection.
🐛
Fix detection of dropzonejs dist files for versions < 6
Active
@sanduhrs
When trying to enable la_eu_default_content it fails because of missing module dependency:
The following module(s) will be enabled: la_eu_default_content, default_content
// Do you want to continue?: yes.
In ExtensionList.php line 524:
The module swiftmailer does not exist.
Script drush pm:enable la_eu_default_content -y handling the __exec_command event returned with error code 1
Patch #39 works fine on
https://www.drupal.org/project/la_eu →
So another +1
Changes on github: https://github.com/thunder/paragraphs_features/pull/77
For triggering creation of a sanitized db artifact, simply trigger a pipeline on 'staging' branch.
You can see a job and artifact here:
https://git.drupalcode.org/project/la_eu/-/jobs/470059
Added phpcs.xml.dist, required drupal/coder.
This pipeline shows cs errors: https://git.drupalcode.org/project/la_eu/-/pipelines/60120
In this pipeline cs errors are fixed: https://git.drupalcode.org/project/la_eu/-/pipelines/60122
Tested this in drupal 10.1 standard profile and chrome:
* Create paragraph type text with text, formatted long field
* Add paragraphs field to article
* Add Split Paragraph Button to Basic HTML Input filter
On the create article (node/add/article) route I get js warning in console
ckeditor5-dll.js?v=39.0.1:5 toolbarview-item-unavailable {item: 'splitParagraph'}
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-toolbarview-item-unavailable
Pasting some text into the text paragraph, position cursor somewhere in the text and clicking the
split paragraph buttton in ck toolbar I get
ckeditor5-dll.js?v=39.0.1:5 Uncaught TypeError: this.splitNode is not a function or its return value is not iterable
at split_paragraph.js?s42b6u:1:1261
Additionaly there is not build step config for rebuilding the js in build dir.
Add .nvmrc to specify node version used.
Re-opened this issue because 🐛 CKEditor 5 toolbar items of multi-value field (typically Paragraphs) overflowing on narrow viewports and overlapping with node form's sidebar on wide viewports Active does not fix things for nested paragraph widgets.
When the media edit form (and others) are loaded in ajax context (overlays, etc) assure that gin content form layout is not applied.
volkerk → made their first commit to this issue’s fork.
volkerk → made their first commit to this issue’s fork.
chr.fritsch → credited volkerk → .
Needs patch from https://www.drupal.org/project/gin/issues/3375350 🐛 gin-table-scroll-wrapper prevents nested paragraph buttons from being clickable Fixed as well, we do not have a dependency on gin, so we cannot add the patch here.
Nice
lgtm
Tested with thunder 6.5.x, lgtm.
"Place block" looks good now.
Added margins for the "Paragraphs Add dialog
Drupal 10 version of the patch.
I tested again with drupal 9.5, drupal 10 using standard profile, with chrome latest and firefox esr on macos.
Strange enough positioning of the dialog close icon is too low for me under all of these conditions.
I did a different solution now, similar to what claro is doing.
Issue #2901158: Changes are lost when collapsing a paragraphs subform including an inline_entity_form → was reverted due to regression. Continuing work in 🐛 Changes are lost when collapsing a paragraphs subform including an inline_entity_form Needs work
@heddn can you elaborate on the regression you mentioned in the reverted #2901158: Changes are lost when collapsing a paragraphs subform including an inline_entity_form →
This commit caused regressions with non paragraph IEF fields. I have an (albiet complex) IEF implementation for user that completely broke after this commit. Any chance this could see a revert while a test coverage and fixes are added?
I guess we need a test for this, otherwise this issue is going nowhere.