Account created on 23 April 2006, almost 19 years ago
  • Senior Software Developer at Thunder 
#

Merge Requests

More

Recent comments

🇩🇪Germany volkerk

volkerk made their first commit to this issue’s fork.

🇩🇪Germany volkerk

Use once to add eventlistener for button sync. Added mousedown event in case of ajax buttons, see 🐛 custom ajax button not working anymore Active

🇩🇪Germany volkerk

volkerk made their first commit to this issue’s fork.

🇩🇪Germany volkerk

volkerk made their first commit to this issue’s fork.

🇩🇪Germany volkerk

volkerk made their first commit to this issue’s fork.

🇩🇪Germany volkerk

I am unsure what to set here, ckeditor sets calc(var(--ck-spacing-unit)* 0.5); for --ck-spacing-small which comes down to 3,900px. Gin uses --gin-spacing-xxs:#{rem(4px)};.

🇩🇪Germany volkerk

volkerk made their first commit to this issue’s fork.

🇩🇪Germany volkerk

Add patch for project installs.
Its same as social_share-whatsapp_print_pdf-2954288-26.patch but catering to typed_data update, see also 🐛 Fatal error on upgrade of typed_data dependencies RTBC

🇩🇪Germany volkerk

Add patch for project installs.

🇩🇪Germany volkerk

volkerk made their first commit to this issue’s fork.

🇩🇪Germany volkerk

@saschaeggi: Could you please link to the issue in core?

🇩🇪Germany volkerk

I tested this and moving the action buttons to static on configuration pages is a nice touch!
About the more actions dropdown I had a few thougths.

* Does it make sense to have the more actions functionality only kick in when there is more than a number of actions?
Also might be nice to have that configurable.
* I would suggest that we introduce alter functionality to be able to exclude certain actions from the dropdown button.
* I am not sure about having the meta sidebar toggle inside the more dropdown button. It is somehow central to the edit experience and also shows state?

🇩🇪Germany volkerk

volkerk made their first commit to this issue’s fork.

🇩🇪Germany volkerk

Closing since remaining tasks have been fixed.

🇩🇪Germany volkerk

@greenSkin Please do not reopen fixed issues. Support of layout_paragraphs is a feature request.
Please open a new issue.

🇩🇪Germany volkerk

@greenSkin Please add a follow-up for layout paragraphs support.

🇩🇪Germany volkerk

We need a more in depth review other than posting two screenshots.

🇩🇪Germany volkerk

Tested with latest chrome and firefox esr, both default vertical toolbar and experimental new core nav.

Lgtm, nice.

🇩🇪Germany volkerk

Added check for libraries/dropzone/dist/min/dropzone.min.js in the test.
I am not sure for which library version / distribution libraries/dropzone/dropzone-min.js is applicable.

The module folder is concatenated with issue number in mr tests, therefore removed relevant part. See https://git.drupalcode.org/issue/dropzonejs-3424947/-/jobs/973387#L209

🇩🇪Germany volkerk

Ah, I see. Aligned the MR to use only the variant with dist and dot

🇩🇪Germany volkerk

@sanduhrs

When trying to enable la_eu_default_content it fails because of missing module dependency:

The following module(s) will be enabled: la_eu_default_content, default_content

 // Do you want to continue?: yes.                                                                                      


In ExtensionList.php line 524:
                                          
  The module swiftmailer does not exist.  
                                          

Script drush pm:enable la_eu_default_content -y handling the __exec_command event returned with error code 1
🇩🇪Germany volkerk

For triggering creation of a sanitized db artifact, simply trigger a pipeline on 'staging' branch.

You can see a job and artifact here:
https://git.drupalcode.org/project/la_eu/-/jobs/470059

🇩🇪Germany volkerk

Added phpcs.xml.dist, required drupal/coder.
This pipeline shows cs errors: https://git.drupalcode.org/project/la_eu/-/pipelines/60120
In this pipeline cs errors are fixed: https://git.drupalcode.org/project/la_eu/-/pipelines/60122

🇩🇪Germany volkerk

Tested this in drupal 10.1 standard profile and chrome:

* Create paragraph type text with text, formatted long field
* Add paragraphs field to article
* Add Split Paragraph Button to Basic HTML Input filter

On the create article (node/add/article) route I get js warning in console

ckeditor5-dll.js?v=39.0.1:5 toolbarview-item-unavailable {item: 'splitParagraph'} 
Read more: https://ckeditor.com/docs/ckeditor5/latest/support/error-codes.html#error-toolbarview-item-unavailable

Pasting some text into the text paragraph, position cursor somewhere in the text and clicking the
split paragraph buttton in ck toolbar I get

ckeditor5-dll.js?v=39.0.1:5 Uncaught TypeError: this.splitNode is not a function or its return value is not iterable
    at split_paragraph.js?s42b6u:1:1261

Additionaly there is not build step config for rebuilding the js in build dir.
Add .nvmrc to specify node version used.

🇩🇪Germany volkerk

When the media edit form (and others) are loaded in ajax context (overlays, etc) assure that gin content form layout is not applied.

🇩🇪Germany volkerk

volkerk made their first commit to this issue’s fork.

🇩🇪Germany volkerk

volkerk made their first commit to this issue’s fork.

Production build 0.71.5 2024