- Issue created by @sanduhrs
FYI @volkerk changed pipes to show warnings instead of failing:
https://git.drupalcode.org/project/la_eu/-/jobs/412661- 🇩🇪Germany sanduhrs 🇪🇺 Heidelberg, Germany, Europe
PHPCS is using the wrong the standards and checking the wrong files.
Is it possible to reuse already implemented jobs?
See https://git.drupalcode.org/project/gitlab_templates/-/blob/1.0.x/include... - Assigned to volkerk
That is the long term goal and talked with Volker to Wim and Nick about that.
But currently they aren't implemented as reusable and consumable blocks.
For now please describe what standards and paths are wrong for Volker to fix :)- 🇩🇪Germany sanduhrs 🇪🇺 Heidelberg, Germany, Europe
The PHPCS ruleset can be found here:
https://git.drupalcode.org/project/gitlab_templates/-/blob/1.0.x/scripts...
Depends on coder module obviuosly. - Status changed to Needs review
over 1 year ago 7:47pm 6 December 2023 - 🇩🇪Germany volkerk
Added phpcs.xml.dist, required drupal/coder.
This pipeline shows cs errors: https://git.drupalcode.org/project/la_eu/-/pipelines/60120
In this pipeline cs errors are fixed: https://git.drupalcode.org/project/la_eu/-/pipelines/60122 - Status changed to RTBC
over 1 year ago 8:55am 12 December 2023 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Looks good to me! I don't think this will cause any conflict with the other MR's.
-
BramDriesen →
committed 0fdb7667 on 1.0.x authored by
volkerk →
Issue #3405133 by volkerk: Fix code style
-
BramDriesen →
committed 0fdb7667 on 1.0.x authored by
volkerk →
- Status changed to Fixed
over 1 year ago 9:56am 12 December 2023 -
BramDriesen →
committed 0fdb7667 on staging authored by
volkerk →
Issue #3405133 by volkerk: Fix code style
-
BramDriesen →
committed 0fdb7667 on staging authored by
volkerk →
Automatically closed - issue fixed for 2 weeks with no activity.